Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of analyze_vars with specifics for .stat_names #1361

Merged
merged 44 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
4c83153
initial rework of analyze_variables to allow custom stats and better …
Melkiades Dec 10, 2024
c9b8a82
add of initial stats
Melkiades Dec 10, 2024
b647e66
Fix: docs
Melkiades Dec 11, 2024
b2b2969
[skip style] [skip vbump] Restyle files
github-actions[bot] Dec 11, 2024
c113b9e
reducing unneeded complexity
Melkiades Dec 11, 2024
b4e6920
merge
Melkiades Dec 11, 2024
0ac4cae
up
Melkiades Dec 11, 2024
14815f7
fix multiple issues with logicals
Melkiades Dec 11, 2024
bf128e8
fixing all errors and test
Melkiades Dec 12, 2024
c343262
fix docs
Melkiades Dec 12, 2024
783039a
minor fixes
Melkiades Dec 12, 2024
b2b2a5c
add: more tests
Melkiades Dec 16, 2024
e1df39b
minor fixes
Melkiades Dec 19, 2024
1dd2019
[skip style] [skip vbump] Restyle files
github-actions[bot] Dec 19, 2024
461ea9a
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] Dec 19, 2024
fb2b916
fixes and simplifications
Melkiades Dec 26, 2024
b5caa9d
fixing changes in labels handling
Melkiades Dec 26, 2024
ba3e107
adaptation for count occurrences
Melkiades Dec 26, 2024
553bdd3
tie loose ends
Melkiades Dec 26, 2024
db5b018
final fixes
Melkiades Dec 26, 2024
c2f8ca2
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] Dec 26, 2024
956842d
Merge branch 'main' into 1352_fix_stats@main
shajoezhu Jan 9, 2025
cee413a
update doc
shajoezhu Jan 13, 2025
a3d0cd4
fix test
shajoezhu Jan 13, 2025
fa25943
use as.facotr instead
shajoezhu Jan 13, 2025
2908900
update example
shajoezhu Jan 13, 2025
ef23cad
update doc
shajoezhu Jan 13, 2025
f607e90
stash changes
shajoezhu Jan 15, 2025
35886b5
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] Jan 15, 2025
628b4e4
update test case
shajoezhu Jan 15, 2025
acebbaa
updatE
shajoezhu Jan 15, 2025
010bd5e
change default value
shajoezhu Jan 15, 2025
96e738b
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] Jan 15, 2025
4aeb61c
update
shajoezhu Jan 15, 2025
231b959
Merge branch '1352_fix_stats@main' of github.com:insightsengineering/…
shajoezhu Jan 15, 2025
8a2d986
Merge remote-tracking branch 'origin/1352_fix_stats@main' into 1352_f…
edelarua Jan 15, 2025
707336b
Documentation improvements
edelarua Jan 15, 2025
f56fd96
Update compare_vars documentation
edelarua Jan 15, 2025
544769c
Fix inconsistencies
edelarua Jan 15, 2025
b9b4796
Fix missing NAs
edelarua Jan 15, 2025
071d884
Set seed in tests
edelarua Jan 15, 2025
d2e1ee3
Add project id
edelarua Jan 15, 2025
d308f61
Merge branch '1352_fix_stats@main' of github.com:insightsengineering/…
shajoezhu Jan 16, 2025
5f8bb27
update workflow
shajoezhu Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ export(get_formats_from_stats)
export(get_indents_from_stats)
export(get_labels_from_stats)
export(get_smooths)
export(get_stat_names)
export(get_stats)
export(groups_list_to_df)
export(h_adlb_abnormal_by_worst_grade)
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,19 @@
* Added `as_list` parameter to `g_lineplot()` to allow users to return the line plot and annotation table elements as a list instead of stacked for more complex customization.
* Refactored `summarize_change()` to work without `make_afun()` and access all additional function parameter.
* Added vignette "Understanding `tern` functions" for future reference.
* Refactored `analyze_vars()` and `a_summary()` to take all options from `?rtables::additional_fun_params`.
* Added to `analyze_vars()` statistical names that are used by `rtables::as_result_df()`.
* Merged `compare_vars()` into `analyze_vars()` as overlap was significant.
* Added the possibility to integrate custom statistical functions to default ones in `analyze_vars()`.
* Reworked `get_labels_from_stats()` to use a named list of levels for each statistic instead of row names.

### Bug Fixes
* Fixed bug in `a_summary()` causing non-unique `row_name` values to occur when multiple statistics are selected for count variables.

### Miscellaneous
* Reverted deprecation of quick get functions `summary_formats()` and `summary_labels()`. Added disclaimer about underlying use of `get_stats`.
* Corrected handling of extra arguments and `NA` for `summarize_change()`.
* Removed `count_fraction_fixed_dp` exception by assigning it to the result of `count_fraction` with a different format output.

# tern 0.9.6

Expand Down
Loading
Loading