Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nestcolor from suggests to import #1312

Closed
shajoezhu opened this issue Sep 20, 2024 · 0 comments · Fixed by #1339
Closed

Move nestcolor from suggests to import #1312

shajoezhu opened this issue Sep 20, 2024 · 0 comments · Fixed by #1339
Assignees
Labels

Comments

@shajoezhu
Copy link
Contributor

          I don't really want to drop "nestcolor::theme_nest()" from the g_lineplot default option, reason being this is primarily used by roche, and the nest default values are set for a reason, 

I don't want to replace the usage of nestcolor either, feel like this is going backwards, and adding code that we have to maintain in tern ...

one possibility is to move nestcolor from suggests to import @pawelru @khatril , what do you guys think?

Originally posted by @shajoezhu in #1293 (comment)

@shajoezhu shajoezhu added the sme label Sep 20, 2024
@edelarua edelarua self-assigned this Oct 24, 2024
edelarua added a commit that referenced this issue Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants