Move nestcolor to imports (#1339)

# Pull Request Fixes #1312 and #1338
insightsengineering · Oct 25, 2024 · 9aff4f9 · 9aff4f9
1 parent cf9fbb0
commit 9aff4f9
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -33,6 +33,7 @@ repos:
           - magrittr
           - MASS
           - methods
+          - nestcolor
           - Rdpack
           - rlang
           - scales

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -44,6 +44,7 @@ Imports:
     magrittr (>= 1.5),
     MASS (>= 7.3-60),
     methods,
+    nestcolor (>= 0.1.1),
     Rdpack (>= 2.4),
     rlang (>= 1.1.0),
     scales (>= 1.2.0),
@@ -56,7 +57,6 @@ Suggests:
     knitr (>= 1.42),
     lattice (>= 0.18-4),
     lubridate (>= 1.7.9),
-    nestcolor (>= 0.1.1),
     rmarkdown (>= 2.23),
     stringr (>= 1.4.1),
     svglite (>= 2.1.2),

diff --git a/tests/testthat/test-individual_patient_plot.R b/tests/testthat/test-individual_patient_plot.R
@@ -3,9 +3,6 @@ adlb <- tern_ex_adlb %>%
   slice(1:36)
 
 testthat::test_that("h_g_ipp works correctly", {
-  skip_if_not_installed("nestcolor")
-  require("nestcolor", quietly = TRUE)
-
   testthat::expect_silent(h_g_ipp(
     df = adlb,
     xvar = "AVISIT",

diff --git a/vignettes/tern.Rmd b/vignettes/tern.Rmd
@@ -133,7 +133,7 @@ adlb <- formatters::ex_adlb
 adlb <- dplyr::filter(adlb, PARAMCD == "ALT", AVISIT != "SCREENING")
 ```
 
-The optional `nestcolor` package can be loaded in to apply the standardized NEST color palette to all `tern` plots.
+The `nestcolor` package can be loaded in to apply the standardized NEST color palette to all `tern` plots.
 
 ```{r}
 library(nestcolor)
-Original file line number
+Diff line change
@@ Expand Up / @@ -33,6 +33,7 @@ repos: @@
               - magrittr
               - MASS
               - methods
+              - nestcolor
               - Rdpack
               - rlang
               - scales
@@ Expand Down @@