Fix the datanames bug causing teal app to crash when teal_data has non standard object names
#2351
GitHub Actions / Unit Tests Summary
failed
Oct 8, 2024 in 0s
12 fail, 46 skipped, 196 pass in 9m 12s
1 files 25 suites 9m 12s ⏱️
254 tests 196 ✅ 46 💤 12 ❌
453 runs 394 ✅ 46 💤 13 ❌
Results for commit 0144176.
Annotations
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
1 out of 2 runs failed: creation_process_is_invoked_for_teal.lockfile.mode_enabled_and_snapshot_is_copied_to_teal_app.lock_and_removed_after_session_ended (module_teal)
teal.Rcheck/tests/testthat/junit-result.xml [took 8m 21s]
Raw output
file.exists(renv_filename) is not TRUE ('test-module_teal.R:90:13')
file.exists(renv_filename) is not TRUE
`actual`: FALSE
`expected`: TRUE
Backtrace:
▆
1. ├─withr::with_options(...) at test-module_teal.R:73:5
2. │ └─base::force(code)
3. ├─shiny::testServer(...) at test-module_teal.R:77:9
4. │ ├─shiny:::withMockContext(...)
5. │ │ ├─shiny::isolate(...)
6. │ │ │ ├─shiny::..stacktraceoff..(...)
7. │ │ │ └─ctx$run(...)
8. │ │ │ ├─promises::with_promise_domain(...)
9. │ │ │ │ └─domain$wrapSync(expr)
10. │ │ │ ├─shiny::withReactiveDomain(...)
11. │ │ │ │ └─promises::with_promise_domain(...)
12. │ │ │ │ └─domain$wrapSync(expr)
13. │ │ │ │ └─base::force(expr)
14. │ │ │ └─env$runWith(self, func)
15. │ │ │ └─shiny (local) contextFunc()
16. │ │ │ └─shiny::..stacktraceon..(expr)
17. │ │ ├─shiny::withReactiveDomain(...)
18. │ │ │ └─promises::with_promise_domain(...)
19. │ │ │ └─domain$wrapSync(expr)
20. │ │ │ └─base::force(expr)
21. │ │ └─withr::with_options(...)
22. │ │ └─base::force(code)
23. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
24. └─testthat::expect_true(file.exists(renv_filename)) at test-module_teal.R:90:13
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
1 out of 2 runs failed: receives_data_with_datasets_module_datanames (module_teal)
teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output
teal.data::datanames((modules_output$module_1())()) not identical to "iris". ('test-module_teal.R:514:9')
teal.data::datanames((modules_output$module_1())()) not identical to "iris".
Lengths differ: 2 is not 1
Backtrace:
▆
1. ├─shiny::testServer(...) at test-module_teal.R:503:5
2. │ ├─shiny:::withMockContext(...)
3. │ │ ├─shiny::isolate(...)
4. │ │ │ ├─shiny::..stacktraceoff..(...)
5. │ │ │ └─ctx$run(...)
6. │ │ │ ├─promises::with_promise_domain(...)
7. │ │ │ │ └─domain$wrapSync(expr)
8. │ │ │ ├─shiny::withReactiveDomain(...)
9. │ │ │ │ └─promises::with_promise_domain(...)
10. │ │ │ │ └─domain$wrapSync(expr)
11. │ │ │ │ └─base::force(expr)
12. │ │ │ └─env$runWith(self, func)
13. │ │ │ └─shiny (local) contextFunc()
14. │ │ │ └─shiny::..stacktraceon..(expr)
15. │ │ ├─shiny::withReactiveDomain(...)
16. │ │ │ └─promises::with_promise_domain(...)
17. │ │ │ └─domain$wrapSync(expr)
18. │ │ │ └─base::force(expr)
19. │ │ └─withr::with_options(...)
20. │ │ └─base::force(code)
21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
22. └─testthat::expect_identical(...) at test-module_teal.R:514:9
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
throws_warning_when_dataname_is_not_available (module_teal) failed
teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output
trimws(rvest::html_text2(rvest::read_html(output[["teal_modules-module_1-validate_datanames-shiny_warnings-message"]]$html))) not equal to "Dataset iris is missing. No datasets are available in data.". ('test-module_teal.R:534:9')
trimws(rvest::html_text2(rvest::read_html(output[["teal_modules-module_1-validate_datanames-shiny_warnings-message"]]$html))) not equal to "Dataset iris is missing. No datasets are available in data.".
1/1 mismatches
x[1]: "Dataset iris is missing. Dataset available in data: mtcars."
y[1]: "Dataset iris is missing. No datasets are available in data."
Backtrace:
▆
1. ├─shiny::testServer(...) at test-module_teal.R:522:5
2. │ ├─shiny:::withMockContext(...)
3. │ │ ├─shiny::isolate(...)
4. │ │ │ ├─shiny::..stacktraceoff..(...)
5. │ │ │ └─ctx$run(...)
6. │ │ │ ├─promises::with_promise_domain(...)
7. │ │ │ │ └─domain$wrapSync(expr)
8. │ │ │ ├─shiny::withReactiveDomain(...)
9. │ │ │ │ └─promises::with_promise_domain(...)
10. │ │ │ │ └─domain$wrapSync(expr)
11. │ │ │ │ └─base::force(expr)
12. │ │ │ └─env$runWith(self, func)
13. │ │ │ └─shiny (local) contextFunc()
14. │ │ │ └─shiny::..stacktraceon..(expr)
15. │ │ ├─shiny::withReactiveDomain(...)
16. │ │ │ └─promises::with_promise_domain(...)
17. │ │ │ └─domain$wrapSync(expr)
18. │ │ │ └─base::force(expr)
19. │ │ └─withr::with_options(...)
20. │ │ └─base::force(code)
21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
22. └─testthat::expect_equal(...) at test-module_teal.R:534:9
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
receives_all_objects_from_env_when_module_datanames_all_ (module_teal) failed
teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output
teal.data::datanames((modules_output$module_1())()) not identical to c("iris", "iris_raw", "mtcars", "swiss"). ('test-module_teal.R:581:9')
teal.data::datanames((modules_output$module_1())()) not identical to c("iris", "iris_raw", "mtcars", "swiss").
3/4 mismatches
x[2]: "mtcars"
y[2]: "iris_raw"
x[3]: "swiss"
y[3]: "mtcars"
x[4]: "iris_raw"
y[4]: "swiss"
Backtrace:
▆
1. ├─shiny::testServer(...) at test-module_teal.R:567:5
2. │ ├─shiny:::withMockContext(...)
3. │ │ ├─shiny::isolate(...)
4. │ │ │ ├─shiny::..stacktraceoff..(...)
5. │ │ │ └─ctx$run(...)
6. │ │ │ ├─promises::with_promise_domain(...)
7. │ │ │ │ └─domain$wrapSync(expr)
8. │ │ │ ├─shiny::withReactiveDomain(...)
9. │ │ │ │ └─promises::with_promise_domain(...)
10. │ │ │ │ └─domain$wrapSync(expr)
11. │ │ │ │ └─base::force(expr)
12. │ │ │ └─env$runWith(self, func)
13. │ │ │ └─shiny (local) contextFunc()
14. │ │ │ └─shiny::..stacktraceon..(expr)
15. │ │ ├─shiny::withReactiveDomain(...)
16. │ │ │ └─promises::with_promise_domain(...)
17. │ │ │ └─domain$wrapSync(expr)
18. │ │ │ └─base::force(expr)
19. │ │ └─withr::with_options(...)
20. │ │ └─base::force(code)
21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
22. └─testthat::expect_identical(...) at test-module_teal.R:581:9
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
receives_all_transform_datasets_if_module_datanames_all_ (module_teal) failed
teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output
teal.data::datanames((modules_output$module_1())()) not identical to c("iris", "mtcars", "swiss"). ('test-module_teal.R:646:9')
teal.data::datanames((modules_output$module_1())()) not identical to c("iris", "mtcars", "swiss").
Lengths differ: 2 is not 3
Backtrace:
▆
1. ├─shiny::testServer(...) at test-module_teal.R:615:5
2. │ ├─shiny:::withMockContext(...)
3. │ │ ├─shiny::isolate(...)
4. │ │ │ ├─shiny::..stacktraceoff..(...)
5. │ │ │ └─ctx$run(...)
6. │ │ │ ├─promises::with_promise_domain(...)
7. │ │ │ │ └─domain$wrapSync(expr)
8. │ │ │ ├─shiny::withReactiveDomain(...)
9. │ │ │ │ └─promises::with_promise_domain(...)
10. │ │ │ │ └─domain$wrapSync(expr)
11. │ │ │ │ └─base::force(expr)
12. │ │ │ └─env$runWith(self, func)
13. │ │ │ └─shiny (local) contextFunc()
14. │ │ │ └─shiny::..stacktraceon..(expr)
15. │ │ ├─shiny::withReactiveDomain(...)
16. │ │ │ └─promises::with_promise_domain(...)
17. │ │ │ └─domain$wrapSync(expr)
18. │ │ │ └─base::force(expr)
19. │ │ └─withr::with_options(...)
20. │ │ └─base::force(code)
21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
22. └─testthat::expect_identical(...) at test-module_teal.R:646:9
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
receives_all_datasets_if_transform_datanames_all_ (module_teal) failed
teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output
teal.data::datanames((modules_output$module_1())()) not identical to c("iris", "mtcars", "swiss"). ('test-module_teal.R:683:9')
teal.data::datanames((modules_output$module_1())()) not identical to c("iris", "mtcars", "swiss").
Lengths differ: 2 is not 3
Backtrace:
▆
1. ├─shiny::testServer(...) at test-module_teal.R:652:5
2. │ ├─shiny:::withMockContext(...)
3. │ │ ├─shiny::isolate(...)
4. │ │ │ ├─shiny::..stacktraceoff..(...)
5. │ │ │ └─ctx$run(...)
6. │ │ │ ├─promises::with_promise_domain(...)
7. │ │ │ │ └─domain$wrapSync(expr)
8. │ │ │ ├─shiny::withReactiveDomain(...)
9. │ │ │ │ └─promises::with_promise_domain(...)
10. │ │ │ │ └─domain$wrapSync(expr)
11. │ │ │ │ └─base::force(expr)
12. │ │ │ └─env$runWith(self, func)
13. │ │ │ └─shiny (local) contextFunc()
14. │ │ │ └─shiny::..stacktraceon..(expr)
15. │ │ ├─shiny::withReactiveDomain(...)
16. │ │ │ └─promises::with_promise_domain(...)
17. │ │ │ └─domain$wrapSync(expr)
18. │ │ │ └─base::force(expr)
19. │ │ └─withr::with_options(...)
20. │ │ └─base::force(code)
21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
22. └─testthat::expect_identical(...) at test-module_teal.R:683:9
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
receives_all_raw_datasets_based_on_module_datanames (module_teal) failed
teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output
ls((modules_output$module_1())()[[".raw_data"]]) (`actual`) and c("iris", "swiss") (`expected`) don't have the same values. ('test-module_teal.R:711:9')
ls((modules_output$module_1())()[[".raw_data"]]) (`actual`) and c("iris", "swiss") (`expected`) don't have the same values.
* Only in `expected`: "mtcars"
Backtrace:
▆
1. ├─shiny::testServer(...) at test-module_teal.R:689:5
2. │ ├─shiny:::withMockContext(...)
3. │ │ ├─shiny::isolate(...)
4. │ │ │ ├─shiny::..stacktraceoff..(...)
5. │ │ │ └─ctx$run(...)
6. │ │ │ ├─promises::with_promise_domain(...)
7. │ │ │ │ └─domain$wrapSync(expr)
8. │ │ │ ├─shiny::withReactiveDomain(...)
9. │ │ │ │ └─promises::with_promise_domain(...)
10. │ │ │ │ └─domain$wrapSync(expr)
11. │ │ │ │ └─base::force(expr)
12. │ │ │ └─env$runWith(self, func)
13. │ │ │ └─shiny (local) contextFunc()
14. │ │ │ └─shiny::..stacktraceon..(expr)
15. │ │ ├─shiny::withReactiveDomain(...)
16. │ │ │ └─promises::with_promise_domain(...)
17. │ │ │ └─domain$wrapSync(expr)
18. │ │ │ └─base::force(expr)
19. │ │ └─withr::with_options(...)
20. │ │ └─base::force(code)
21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
22. └─testthat::expect_setequal(...) at test-module_teal.R:711:9
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
combines_datanames_from_transform_module_datanames (module_teal) failed
teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output
teal.data::datanames((modules_output$module_1())()) not identical to c("iris", "mtcars", "swiss"). ('test-module_teal.R:744:9')
teal.data::datanames((modules_output$module_1())()) not identical to c("iris", "mtcars", "swiss").
1/3 mismatches
x[3]: "not_included"
y[3]: "swiss"
Backtrace:
▆
1. ├─shiny::testServer(...) at test-module_teal.R:717:5
2. │ ├─shiny:::withMockContext(...)
3. │ │ ├─shiny::isolate(...)
4. │ │ │ ├─shiny::..stacktraceoff..(...)
5. │ │ │ └─ctx$run(...)
6. │ │ │ ├─promises::with_promise_domain(...)
7. │ │ │ │ └─domain$wrapSync(expr)
8. │ │ │ ├─shiny::withReactiveDomain(...)
9. │ │ │ │ └─promises::with_promise_domain(...)
10. │ │ │ │ └─domain$wrapSync(expr)
11. │ │ │ │ └─base::force(expr)
12. │ │ │ └─env$runWith(self, func)
13. │ │ │ └─shiny (local) contextFunc()
14. │ │ │ └─shiny::..stacktraceon..(expr)
15. │ │ ├─shiny::withReactiveDomain(...)
16. │ │ │ └─promises::with_promise_domain(...)
17. │ │ │ └─domain$wrapSync(expr)
18. │ │ │ └─base::force(expr)
19. │ │ └─withr::with_options(...)
20. │ │ └─base::force(code)
21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
22. └─testthat::expect_identical(...) at test-module_teal.R:744:9
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
All 2 runs failed: receives_all_possible_objects_while_those_not_specified_in_module_datanames_are_unfiltered (module_teal)
teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output
data_from_transform$mtcars not identical to `mtcars`. ('test-module_teal.R:1582:9')
data_from_transform$mtcars not identical to `mtcars`.
target is NULL, current is data.frame
Backtrace:
▆
1. ├─shiny::testServer(...) at test-module_teal.R:1546:5
2. │ ├─shiny:::withMockContext(...)
3. │ │ ├─shiny::isolate(...)
4. │ │ │ ├─shiny::..stacktraceoff..(...)
5. │ │ │ └─ctx$run(...)
6. │ │ │ ├─promises::with_promise_domain(...)
7. │ │ │ │ └─domain$wrapSync(expr)
8. │ │ │ ├─shiny::withReactiveDomain(...)
9. │ │ │ │ └─promises::with_promise_domain(...)
10. │ │ │ │ └─domain$wrapSync(expr)
11. │ │ │ │ └─base::force(expr)
12. │ │ │ └─env$runWith(self, func)
13. │ │ │ └─shiny (local) contextFunc()
14. │ │ │ └─shiny::..stacktraceon..(expr)
15. │ │ ├─shiny::withReactiveDomain(...)
16. │ │ │ └─promises::with_promise_domain(...)
17. │ │ │ └─domain$wrapSync(expr)
18. │ │ │ └─base::force(expr)
19. │ │ └─withr::with_options(...)
20. │ │ └─base::force(code)
21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
22. └─testthat::expect_identical(data_from_transform$mtcars, mtcars) at test-module_teal.R:1582:9
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
reflects_transform_adding_new_dataset_if_specified_in_module (module_teal) failed
teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output
module_summary_table(output, "module_1") not identical to data.frame(...). ('test-module_teal.R:1945:9')
module_summary_table(output, "module_1") not identical to data.frame(...).
Attributes: < Component "row.names": Numeric: lengths (1, 2) differ >
Component "Data Name": Lengths (1, 2) differ (string compare on first 1)
Component "Obs": Lengths (1, 2) differ (string compare on first 1)
Backtrace:
▆
1. ├─shiny::testServer(...) at test-module_teal.R:1920:5
2. │ ├─shiny:::withMockContext(...)
3. │ │ ├─shiny::isolate(...)
4. │ │ │ ├─shiny::..stacktraceoff..(...)
5. │ │ │ └─ctx$run(...)
6. │ │ │ ├─promises::with_promise_domain(...)
7. │ │ │ │ └─domain$wrapSync(expr)
8. │ │ │ ├─shiny::withReactiveDomain(...)
9. │ │ │ │ └─promises::with_promise_domain(...)
10. │ │ │ │ └─domain$wrapSync(expr)
11. │ │ │ │ └─base::force(expr)
12. │ │ │ └─env$runWith(self, func)
13. │ │ │ └─shiny (local) contextFunc()
14. │ │ │ └─shiny::..stacktraceon..(expr)
15. │ │ ├─shiny::withReactiveDomain(...)
16. │ │ │ └─promises::with_promise_domain(...)
17. │ │ │ └─domain$wrapSync(expr)
18. │ │ │ └─base::force(expr)
19. │ │ └─withr::with_options(...)
20. │ │ └─base::force(code)
21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
22. └─testthat::expect_identical(...) at test-module_teal.R:1945:9
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
displays_only_module_datanames (module_teal) failed
teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output
module_summary_table(output, "module_1") not identical to data.frame(`Data Name` = c("iris"), Obs = c("150/150"), check.names = FALSE). ('test-module_teal.R:1998:9')
module_summary_table(output, "module_1") not identical to data.frame(`Data Name` = c("iris"), Obs = c("150/150"), check.names = FALSE).
Attributes: < Component "row.names": Numeric: lengths (2, 1) differ >
Component "Data Name": Lengths (2, 1) differ (string compare on first 1)
Component "Obs": Lengths (2, 1) differ (string compare on first 1)
Backtrace:
▆
1. ├─shiny::testServer(...) at test-module_teal.R:1989:5
2. │ ├─shiny:::withMockContext(...)
3. │ │ ├─shiny::isolate(...)
4. │ │ │ ├─shiny::..stacktraceoff..(...)
5. │ │ │ └─ctx$run(...)
6. │ │ │ ├─promises::with_promise_domain(...)
7. │ │ │ │ └─domain$wrapSync(expr)
8. │ │ │ ├─shiny::withReactiveDomain(...)
9. │ │ │ │ └─promises::with_promise_domain(...)
10. │ │ │ │ └─domain$wrapSync(expr)
11. │ │ │ │ └─base::force(expr)
12. │ │ │ └─env$runWith(self, func)
13. │ │ │ └─shiny (local) contextFunc()
14. │ │ │ └─shiny::..stacktraceon..(expr)
15. │ │ ├─shiny::withReactiveDomain(...)
16. │ │ │ └─promises::with_promise_domain(...)
17. │ │ │ └─domain$wrapSync(expr)
18. │ │ │ └─base::force(expr)
19. │ │ └─withr::with_options(...)
20. │ │ └─base::force(code)
21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
22. └─testthat::expect_identical(...) at test-module_teal.R:1998:9
Check warning on line 0 in module_teal
github-actions / Unit Tests Summary
displays_subset_of_module_datanames_if_not_sufficient (module_teal) failed
teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output
module_summary_table(output, "module_1") not identical to data.frame(`Data Name` = c("iris"), Obs = c("150/150"), check.names = FALSE). ('test-module_teal.R:2046:9')
module_summary_table(output, "module_1") not identical to data.frame(`Data Name` = c("iris"), Obs = c("150/150"), check.names = FALSE).
Attributes: < Component "row.names": Numeric: lengths (2, 1) differ >
Component "Data Name": Lengths (2, 1) differ (string compare on first 1)
Component "Obs": Lengths (2, 1) differ (string compare on first 1)
Backtrace:
▆
1. ├─shiny::testServer(...) at test-module_teal.R:2036:5
2. │ ├─shiny:::withMockContext(...)
3. │ │ ├─shiny::isolate(...)
4. │ │ │ ├─shiny::..stacktraceoff..(...)
5. │ │ │ └─ctx$run(...)
6. │ │ │ ├─promises::with_promise_domain(...)
7. │ │ │ │ └─domain$wrapSync(expr)
8. │ │ │ ├─shiny::withReactiveDomain(...)
9. │ │ │ │ └─promises::with_promise_domain(...)
10. │ │ │ │ └─domain$wrapSync(expr)
11. │ │ │ │ └─base::force(expr)
12. │ │ │ └─env$runWith(self, func)
13. │ │ │ └─shiny (local) contextFunc()
14. │ │ │ └─shiny::..stacktraceon..(expr)
15. │ │ ├─shiny::withReactiveDomain(...)
16. │ │ │ └─promises::with_promise_domain(...)
17. │ │ │ └─domain$wrapSync(expr)
18. │ │ │ └─base::force(expr)
19. │ │ └─withr::with_options(...)
20. │ │ └─base::force(code)
21. │ └─rlang::eval_tidy(quosure, mask, rlang::caller_env())
22. └─testthat::expect_identical(...) at test-module_teal.R:2046:9
Loading