Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation for teal_slices #970

Merged
merged 11 commits into from
Nov 22, 2023
Merged

Conversation

kartikeyakirar
Copy link
Contributor

@kartikeyakirar kartikeyakirar commented Nov 21, 2023

Closes #966.

Here as per discussion I have added module_specific parameter in vignettes example and updated documentation for module_specific paramter

Copy link
Contributor

github-actions bot commented Nov 21, 2023

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                 92      50  45.65%   9-71
R/get_rcode_utils.R                 38       1  97.37%   50
R/include_css_js.R                  24       0  100.00%
R/init.R                            79      25  68.35%   139, 164-185, 217-219, 221-223, 225-226
R/landing_popup_module.R            25      25  0.00%    61-87
R/module_filter_manager.R          107      29  72.90%   62-70, 79-84, 228, 233-246
R/module_nested_tabs.R             174      14  91.95%   72, 119, 138-145, 163, 216, 238, 271
R/module_snapshot_manager.R        209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 346-369
R/module_tabs_with_filters.R        73       2  97.26%   95, 140
R/module_teal_with_splash.R        120      11  90.83%   73, 87-95, 122
R/module_teal.R                    141       8  94.33%   68, 71, 158-159, 165, 196, 204-205
R/modules_debugging.R               18      18  0.00%    25-44
R/modules.R                        143      26  81.82%   119, 132, 226-229, 243-248, 259-263, 378-421
R/reporter_previewer_module.R       18       2  88.89%   26, 30
R/show_rcode_modal.R                20      20  0.00%    16-37
R/tdata.R                           39       1  97.44%   158
R/teal_data_module.R                 6       0  100.00%
R/teal_reporter.R                   60       5  91.67%   65, 116-117, 120, 137
R/teal_slices-store.R               25       0  100.00%
R/teal_slices.R                     59      12  79.66%   135-148
R/utils.R                          108      27  75.00%   113-140
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     58      37  36.21%   109-371
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1679     477  71.59%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 13ecba4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 21, 2023

Unit Tests Summary

    1 files    18 suites   12s ⏱️
195 tests 195 ✔️ 0 💤 0
367 runs  367 ✔️ 0 💤 0

Results for commit 13ecba4.

♻️ This comment has been updated with latest results.

R/teal_slices.R Outdated Show resolved Hide resolved
vignettes/filter-panel.Rmd Outdated Show resolved Hide resolved
vignettes/filter-panel.Rmd Outdated Show resolved Hide resolved
@chlebowa chlebowa changed the title updated document for arg module_specific update documentation for teal_slices Nov 21, 2023
@chlebowa chlebowa self-assigned this Nov 21, 2023
kartikeyakirar and others added 7 commits November 22, 2023 10:51
Co-authored-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kartikeyakirar kartikeyakirar enabled auto-merge (squash) November 22, 2023 13:02
@kartikeyakirar kartikeyakirar merged commit 210a4d9 into main Nov 22, 2023
22 of 23 checks passed
@kartikeyakirar kartikeyakirar deleted the 966_update_doc@main branch November 22, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The mapping in teal_slice is lost
3 participants