-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
198 extension to Include user's card labels when generating the report #933
Conversation
Co-authored-by: Marcin <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
@kartikeyakirar some checks are failing. can you have a look? EDIT: Agh, this is this staged.dependencies acyclic test https://github.com/insightsengineering/teal/actions/runs/6493700551/job/17635159937?pr=933#step:15:111 Started this on main branch to see if it was already there https://github.com/insightsengineering/teal/actions/runs/6493907739 |
Ok, the action on main branch does not fail https://github.com/insightsengineering/teal/actions/runs/6493907739 |
I have no idea why its failing. |
Code Coverage Summary
Diff against main
Results for commit: 4a999c5 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kartikeyakirar looks like this staged deps cyclic error does not appear on this PR anymore. You are good to merge
this PR is extension to insightsengineering/teal.reporter#198
Here I have added card_template() function that generates a report card with a title,
an optional description, and the option to append the filter state list. and is been used in
insightsengineering/teal.modules.general#584
insightsengineering/teal.modules.clinical#835
insightsengineering/teal.modules.hermes#336
insightsengineering/teal.osprey#229
insightsengineering/teal.goshawk#241
ref issues and discussion:
insightsengineering/teal.reporter#226