Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

198 extension to Include user's card labels when generating the report #933

Merged
merged 11 commits into from
Oct 13, 2023

Conversation

kartikeyakirar
Copy link
Contributor

@kartikeyakirar kartikeyakirar commented Oct 12, 2023

this PR is extension to insightsengineering/teal.reporter#198

Here I have added card_template() function that generates a report card with a title,
an optional description, and the option to append the filter state list. and is been used in
insightsengineering/teal.modules.general#584
insightsengineering/teal.modules.clinical#835
insightsengineering/teal.modules.hermes#336
insightsengineering/teal.osprey#229
insightsengineering/teal.goshawk#241

ref issues and discussion:
insightsengineering/teal.reporter#226

@kartikeyakirar kartikeyakirar requested a review from m7pr October 12, 2023 08:44
R/utils.R Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
tests/testthat/test-utils.R Outdated Show resolved Hide resolved
tests/testthat/test-utils.R Outdated Show resolved Hide resolved
tests/testthat/test-utils.R Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
kartikeyakirar and others added 3 commits October 12, 2023 14:44
Co-authored-by: Marcin <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Marcin <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Marcin <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
@m7pr
Copy link
Contributor

m7pr commented Oct 12, 2023

@kartikeyakirar some checks are failing. can you have a look?

EDIT: Agh, this is this staged.dependencies acyclic test https://github.com/insightsengineering/teal/actions/runs/6493700551/job/17635159937?pr=933#step:15:111

Started this on main branch to see if it was already there https://github.com/insightsengineering/teal/actions/runs/6493907739

@m7pr
Copy link
Contributor

m7pr commented Oct 12, 2023

Ok, the action on main branch does not fail https://github.com/insightsengineering/teal/actions/runs/6493907739

@kartikeyakirar
Copy link
Contributor Author

this is this staged.dependencies acyclic test

I have no idea why its failing.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

Unit Tests Summary

    1 files    16 suites   22s ⏱️
172 tests 172 ✔️ 0 💤 0
347 runs  347 ✔️ 0 💤 0

Results for commit 4a999c5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ----------------------------------------------------------------------------------
R/dummy_functions.R                 88      63  28.41%   9-76, 101-104, 107-111
R/get_rcode_utils.R                 46       1  97.83%   49
R/include_css_js.R                  24       0  100.00%
R/init.R                            77      28  63.64%   171-178, 183-204, 216-218
R/module_filter_manager.R          107      29  72.90%   62-70, 79-84, 228, 233-246
R/module_nested_tabs.R             170      16  90.59%   72, 119, 123-124, 138-145, 163, 216, 238, 271
R/module_snapshot_manager.R        148     105  29.05%   71-82, 109-118, 122-134, 136-143, 149-164, 177-200, 203-214, 217-223, 237, 258-281
R/module_tabs_with_filters.R        67       1  98.51%   95
R/module_teal_with_splash.R         33       2  93.94%   65, 77
R/module_teal.R                    164      12  92.68%   68, 71, 158-159, 209-210, 230-233, 235, 239
R/modules_debugging.R               18      18  0.00%    25-44
R/modules.R                        128      22  82.81%   206-211, 222-226, 341-384
R/reporter_previewer_module.R       17       2  88.24%   23, 27
R/show_rcode_modal.R                20      20  0.00%    16-37
R/tdata.R                           41       2  95.12%   146, 172
R/teal_reporter.R                   60       5  91.67%   65, 116-117, 120, 137
R/teal_slices.R                     57      12  78.95%   118-131
R/utils.R                           33       0  100.00%
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     60      37  38.33%   111-373
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1401     382  72.73%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
R/utils.R       +12       0  +100.00%
TOTAL           +12       0  +0.24%

Results for commit: 4a999c5

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@kartikeyakirar kartikeyakirar requested a review from m7pr October 12, 2023 18:11
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kartikeyakirar looks like this staged deps cyclic error does not appear on this PR anymore. You are good to merge

@kartikeyakirar kartikeyakirar merged commit 57fdce9 into main Oct 13, 2023
22 checks passed
@kartikeyakirar kartikeyakirar deleted the 198_card_labels@main branch October 13, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants