-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce teal_data class #925
Conversation
R/module_teal.R
Outdated
if (is.null(raw_data())) { | ||
return(NULL) | ||
} | ||
datasets_reactive <- eventReactive(raw_data(), ignoreNULL = TRUE, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for explicitly setting ignoreNULL
to default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I should remove it because eventReactive has ignoreNULL = TRUE
by default, which is exactly what we need here.
Code Coverage Summary
Diff against main
Results for commit: 2d688f2 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
R/module_teal_with_splash.R
Outdated
# raw_data contains TealDataAbstract, i.e. R6 object and container for data | ||
# reactive to get data through delayed loading | ||
# we must leave it inside the server because of callModule which needs to pick up the right session |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still true?
that's a great simplification to the data specification where one does no longer need to use |
tests/testthat/test-init.R
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should init
accept empty teal_data
?
Currently does but then error is raised by init_filtered_data
downstream.
Signed-off-by: Aleksander Chlebowski <[email protected]>
Followup to: