-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
818 documentation cleanup #869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlebowa
reviewed
Jul 24, 2023
chlebowa
reviewed
Jul 24, 2023
chlebowa
reviewed
Jul 24, 2023
chlebowa
reviewed
Jul 24, 2023
chlebowa
reviewed
Jul 24, 2023
chlebowa
reviewed
Jul 24, 2023
chlebowa
reviewed
Jul 24, 2023
Thanks for review @chlebowa |
chlebowa
reviewed
Jul 24, 2023
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
chlebowa
reviewed
Jul 24, 2023
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
chlebowa
reviewed
Jul 24, 2023
chlebowa
reviewed
Jul 24, 2023
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
chlebowa
reviewed
Jul 24, 2023
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Marcin <[email protected]>
Waiting for #872 |
chlebowa
approved these changes
Jul 27, 2023
Code Coverage Summary
Diff against main
Results for commit: 94d20ea Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #818
With this PR we aimed to explain
teal.code
usage inAdding support for Reporting to custom modules
vignette. This vignette demonstrates the usage ofteal.reporter
modules withteal
apps. The example withteal.code
is not necessary for the vignette however it shows an advanced combination of usage ofteal.code
andteal.reporter
hence I decided not to removeteal.code
snippets from this article.There are also
teal.code
snippets in another vignette (Creating Custom Modules
), so removal from this one would not remove the Suggests dependency for theteal.code
package anyway.I also reviewed the text and tried to polish it.
Lastly, there examples in
R/module_tabs_with_filters.R
were updated during #870