Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quosures in teal and deprecate old show r code approach #721

Merged
merged 25 commits into from
Sep 7, 2022
Merged

quosures in teal and deprecate old show r code approach #721

merged 25 commits into from
Sep 7, 2022

Conversation

nikolas-burkoff
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff commented Aug 19, 2022 •
edited
Loading

Closes #682 and also closes #640

  • The only module I'm not sure what to do with is filter_calls_module

This was referenced Aug 19, 2022
Closed
Closed
@gogonzo
Copy link
Contributor

gogonzo commented Aug 19, 2022

@nikolas-burkoff let's wait with filter_calls_module until we resolve reactivity of attr(data, "code")

@nikolas-burkoff nikolas-burkoff changed the title quosures in teal quosures in teal and deprecate old show r code approach Aug 24, 2022
@nikolas-burkoff nikolas-burkoff mentioned this pull request Aug 24, 2022
Closed
@gogonzo gogonzo marked this pull request as ready for review August 31, 2022 10:25
@gogonzo gogonzo self-assigned this Aug 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022 •
edited
Loading

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------
R/default_filter.R                   7       7  0.00%    17-27
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  17      17  0.00%    19-35
R/get_rcode_utils.R                 52       2  96.15%   94, 99
R/get_rcode.R                      151      54  64.24%   74, 81, 86, 220-286
R/include_css_js.R                  24       0  100.00%
R/init.R                            39      21  46.15%   174, 185-186, 239-260
R/log_app_usage.R                   38      38  0.00%    34-119
R/logging.R                         13      13  0.00%    11-28
R/module_nested_tabs.R             110       7  93.64%   57, 96, 101-102, 148, 197, 226
R/module_tabs_with_filters.R        68       1  98.53%   159
R/module_teal_with_splash.R         33       2  93.94%   62, 74
R/module_teal.R                    119      20  83.19%   49, 52, 142-143, 156-162, 168-174, 197, 227
R/modules_debugging.R               19      19  0.00%    41-60
R/modules.R                        115       9  92.17%   218, 423-448
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/utils.R                            6       0  100.00%
R/validations.R                     62      39  37.10%   103-355
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              990     339  65.76%

Results for commit: 3c3da57

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

gogonzo
gogonzo approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022 •
edited
Loading

Unit Tests Summary

    1 files    10 suites   12s ⏱️
111 tests 111 ✔️ 0 💤 0 ❌
214 runs  214 ✔️ 0 💤 0 ❌

Results for commit 4fefa5b.

♻️ This comment has been updated with latest results.

@gogonzo gogonzo changed the base branch from main to teal_refactor@main September 6, 2022 20:40
@gogonzo gogonzo merged commit 671804f into teal_refactor@main Sep 7, 2022
@gogonzo gogonzo deleted the 26_new_chunks@main branch September 7, 2022 08:33
@gogonzo gogonzo restored the 26_new_chunks@main branch September 7, 2022 08:33
@cicdguy cicdguy deleted the 26_new_chunks@main branch September 24, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polkas Polkas Polkas left review comments

@gogonzo gogonzo gogonzo approved these changes

Assignees

@gogonzo gogonzo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update vignette Deprecate get_rcode_srv
3 participants
@nikolas-burkoff @gogonzo @Polkas