Review decorator vignette #1470
Conversation
| To include decorators in a `teal` module, pass them as arguments (`ui_args` and `server_args`) to the module’s `ui` and | ||
| `server` components, where they will be used by `ui/srv_teal_transform_module`. | ||
| To include decorators in a `teal` module, pass them as arguments (`ui_args` and `server_args`) to the module’s `ui` and | ||
| `server` components, where they will be used by `ui_transform_teal_data` and `srv_transform_teal_data`. |
There was a problem hiding this comment.
@gogonzo am I using the right function name?
There was a problem hiding this comment.
Yes. Closing a conversation
| @@ -510,7 +515,7 @@ interactive_decorator_3 <- teal_transform_module( | |||
|
|
|||
| ### Application | |||
|
|
|||
| As you might have noted, the x axis title from the first decorator will be used but won't show up on the resulting plot: | |||
| As you might have noticed, the x-axis title from the first decorator will be used but will not appear in the resulting plot: | |||
There was a problem hiding this comment.
@gogonzo
Could you please double check the app for this section? From what I can see, only decorator_1 is functional.
No changes to the plot's x or y axis when I toggled to decorator_2 and decorator_3.
Is this as expected?
There was a problem hiding this comment.
Yes, third decorator doesn't make sense.
I think this vignette is too long. There are too many examples doing every possible thing. I think that instead of having a section with multiple decorators there should be a tab in the first example with two decorators. Also the last example with multiple outputs - Yes, it is a real case but come on, let's give app developers space for creativity and let them utilise decorators in their way.
Unit Tests Summary 1 files 28 suites 10m 19s ⏱️ Results for commit 08d3dcf. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit 5fc8359 ♻️ This comment has been updated with latest results. |
Part of insightsengineering/nestdevs-tasks#99