-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TealAppDriver skips tests when shinytest2 or rvest are not installed #1432
Conversation
Code Coverage Summary
Diff against main
Results for commit: 72cc3d8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 27 suites 10m 26s ⏱️ Results for commit 72cc3d8. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit 91be1ca ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code works well, but I am not sure about the readability (but I also don't think my proposal is easier to read)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot to aprove yesterday!
Pull Request
Part of insightsengineering/teal.modules.general#774
See insightsengineering/teal.modules.general#774 (comment)