Remove TealData checks

NEWS.md

@@ -15,6 +15,7 @@
 `datanames` one should modify `module$datanames`.
 * The `landing_popup_module()` needs to be passed as the `landing_popup` argument of `init` instead of being passed as a module of the `modules` argument of `init`.
 * `teal` no longer re-export `%>%`. Please load `library(magrittr)` instead or use `|>` from `base`.
+* `module(server)` parameter does not accept the `datasets` argument.
 
 ### Enhancement
 

R/init.R

@@ -103,16 +103,6 @@ init <- function(data,
 
   # argument checking (independent)
   ## `data`
-  if (inherits(data, "TealData")) {
-    lifecycle::deprecate_stop(
-      when = "0.15.0",
-      what = "init(data)",
-      paste(
-        "TealData is no longer supported. Use teal_data() instead.",
-        "Please follow migration instructions https://github.com/insightsengineering/teal/discussions/988."
-      )
-    )
-  }
   checkmate::assert_multi_class(data, c("teal_data", "teal_data_module"))
   checkmate::assert_class(landing_popup, "teal_module_landing", null.ok = TRUE)
 

R/modules.R

@@ -196,15 +196,6 @@ module <- function(label = "module",
       "\n - `...` server_args elements will be passed to the module named argument or to the `...`"
     )
   }
-  if ("datasets" %in% server_formals) {
-    warning(
-      sprintf("Called from module(label = \"%s\", ...)\n  ", label),
-      "`datasets` argument in the server is deprecated and will be removed in the next release. ",
-      "Please use `data` instead.",
-      call. = FALSE
-    )
-  }
-
 
   ## UI
   checkmate::assert_function(ui)
@@ -217,15 +208,6 @@ module <- function(label = "module",
       "\n - `...` ui_args elements will be passed to the module argument of the same name or to the `...`"
     )
   }
-  if (any(c("data", "datasets") %in% ui_formals)) {
-    stop(
-      sprintf("Called from module(label = \"%s\", ...)\n  ", label),
-      "UI with `data` or `datasets` argument is no longer accepted.\n  ",
-      "If some UI inputs depend on data, please move the logic to your server instead.\n  ",
-      "Possible solutions are renderUI() or updateXyzInput() functions."
-    )
-  }
-
 
   ## `filters`
   if (!missing(filters)) {

tests/testthat/test-module_teal.R

@@ -915,26 +915,6 @@ testthat::describe("srv_teal teal_modules", {
     )
   })
 
-  testthat::it("srv_teal_module.teal_module passes (deprecated) datasets to the server module", {
-    testthat::expect_warning(
-      shiny::testServer(
-        app = srv_teal,
-        args = list(
-          id = "test",
-          data = teal.data::teal_data(iris = iris, mtcars = mtcars),
-          modules = modules(
-            module("module_1", server = function(id, datasets) datasets)
-          )
-        ),
-        expr = {
-          session$setInputs(`teal_modules-active_tab` = "module_1")
-          testthat::expect_s3_class(modules_output$module_1(), "FilteredData")
-        }
-      ),
-      "`datasets` argument in the server is deprecated and will be removed in the next release"
-    )
-  })
-
   testthat::it("srv_teal_module.teal_module passes server_args to the ...", {
     shiny::testServer(
       app = srv_teal,

tests/testthat/test-modules.R

@@ -24,14 +24,6 @@ testthat::test_that("module requires label argument to be a string different tha
   testthat::expect_error(module(label = "global_filters"), "is reserved in teal")
 })
 
-testthat::test_that("module warns when server contains datasets argument", {
-  testthat::expect_warning(
-    module(server = function(id, datasets) NULL),
-    "`datasets` argument in the server is deprecated"
-  )
-})
-
-
 testthat::test_that("module expects server being a shiny server module with any argument", {
   testthat::expect_no_error(module(server = function(id) NULL))
 
@@ -78,11 +70,6 @@ testthat::test_that("module requires ui_args argument to be a list", {
   testthat::expect_error(module(ui_args = list(1, 2, 3)), "Must have names")
 })
 
-testthat::test_that("module throws when ui has data or datasets argument", {
-  testthat::expect_error(module(ui = function(id, data) NULL))
-  testthat::expect_error(module(ui = function(id, datasets) NULL))
-})
-
 testthat::test_that("module expects ui being a shiny ui module with any argument", {
   testthat::expect_no_error(module(ui = function(id) NULL))
   testthat::expect_no_error(module(ui = function(id, any_argument) NULL))