Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust teal after introduction of [.qenv in teal.code and after changes of @code, @warnings, @messages and @id slots #1396

Merged
merged 19 commits into from
Nov 8, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Oct 25, 2024

@m7pr m7pr added the core label Oct 25, 2024
@m7pr m7pr changed the title WIP 211 adjust tests after introduction of subset in teal.code WIP 211 adjust tests after introduction of [.qenv in teal.code Oct 28, 2024
@m7pr m7pr changed the title WIP 211 adjust tests after introduction of [.qenv in teal.code Adjust teal after introduction of [.qenv in teal.code and after changes of @code, @warnings, @messages and @id slots Nov 8, 2024
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.append_evaluated_code is missing all informations needed for @code to work properly.

@m7pr m7pr marked this pull request as ready for review November 8, 2024 13:41
@m7pr
Copy link
Contributor Author

m7pr commented Nov 8, 2024

Hey, marking ready for the review, but I still locally see some issues with test. Still about ~20 failining

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Unit Tests Summary

  1 files   25 suites   8m 57s ⏱️
265 tests 261 ✅ 4 💤 0 ❌
520 runs  516 ✅ 4 💤 0 ❌

Results for commit 7b238bb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-data_summary 💚 $52.83$ $-1.48$ $0$ $0$ $0$ $0$
shinytest2-module_bookmark_manager 💚 $38.15$ $-1.59$ $0$ $0$ $0$ $0$
shinytest2-reporter 💚 $68.93$ $-1.18$ $0$ $0$ $0$ $0$
shinytest2-wunder_bar 💚 $23.05$ $-1.04$ $0$ $0$ $0$ $0$

Results for commit 47a4840

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor Author

m7pr commented Nov 8, 2024

This could have solved a lot of tests insightsengineering/teal.code@6c5d5ab
The change was made in teal.code so I sent an empty commit here to restart the tests

Copy link
Contributor

github-actions bot commented Nov 8, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  47      11  76.60%   27, 29, 41, 52-59
R/get_rcode_utils.R                  12       0  100.00%
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                            108      50  53.70%   107-114, 160-169, 171, 183-204, 229-232, 239-245, 248-249, 251
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     127  19.62%   47-68, 88-138, 143-144, 156, 203, 238-315
R/module_data_summary.R             203      39  80.79%   26-54, 68, 78, 219, 224, 238, 269-273
R/module_filter_data.R               64       2  96.88%   22-23
R/module_filter_manager.R           230      57  75.22%   56-62, 73-82, 90-95, 108-112, 117-118, 291-314, 340, 367, 379, 386-387
R/module_init_data.R                 74       0  100.00%
R/module_nested_tabs.R              236      91  61.44%   40-142, 174, 199-201, 320, 360
R/module_snapshot_manager.R         216     146  32.41%   89-95, 104-113, 121-133, 152-153, 170-180, 184-199, 201-208, 215-230, 234-238, 240-246, 249-262, 265-273, 304-318, 321-332, 335-341, 355
R/module_teal_data.R                149      10  93.29%   41-48, 84, 135-136
R/module_teal_lockfile.R            131      44  66.41%   32-36, 44-56, 59-61, 75, 85-87, 99-101, 109-118, 121, 123, 125-126, 160-161
R/module_teal_with_splash.R          12      12  0.00%    22-38
R/module_teal.R                     190      87  54.21%   48-143, 158, 184-185, 217
R/module_transform_data.R            54      32  40.74%   17-52
R/modules.R                         280      72  74.29%   173-177, 232-235, 356-376, 384, 534-540, 553-562, 578-626, 659, 671-679
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       24       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 58       0  100.00%
R/teal_data_utils.R                  10       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/TealAppDriver.R                   353     353  0.00%    52-735
R/utils.R                           225      37  83.56%   378-426
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              15      11  26.67%   4-18
TOTAL                              3234    1306  59.62%

Diff against main

Filename                   Stmts    Miss  Cover
-----------------------  -------  ------  --------
R/module_data_summary.R        0      +1  -0.49%
R/teal_data_utils.R          -21       0  +100.00%
TOTAL                        -21      +1  -0.29%

Results for commit: 7b238bb

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

R/module_filter_data.R Outdated Show resolved Hide resolved
@gogonzo gogonzo self-assigned this Nov 8, 2024
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gogonzo gogonzo merged commit 41b9f4f into main Nov 8, 2024
28 checks passed
@gogonzo gogonzo deleted the 211_subset@main branch November 8, 2024 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants