-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust teal
after introduction of [.qenv
in teal.code
and after changes of @code
, @warnings
, @messages
and @id
slots
#1396
Conversation
subset
in teal.code
[.qenv
in teal.code
…ing/teal into 211_subset@main
[.qenv
in teal.code
teal
after introduction of [.qenv
in teal.code
and after changes of @code
, @warnings
, @messages
and @id
slots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.append_evaluated_code
is missing all informations needed for @code
to work properly.
Signed-off-by: Marcin <[email protected]>
Hey, marking ready for the review, but I still locally see some issues with test. Still about ~20 failining |
Unit Tests Summary 1 files 25 suites 8m 57s ⏱️ Results for commit 7b238bb. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit 47a4840 ♻️ This comment has been updated with latest results. |
This could have solved a lot of tests insightsengineering/teal.code@6c5d5ab |
Code Coverage Summary
Diff against main
Results for commit: 7b238bb Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Companion of
[.qenv
S3 method + replacement of@id
,@warnings
, and@messages
fields teal.code#216[.teal_data
S3 method teal.data#346