-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-standard datanames in teal .raw_data #1382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to add tests in test-module_teal.R
to confirm that teal
supports what has been just enabled in teal.data
Unit Tests Summary 1 files 25 suites 8m 30s ⏱️ Results for commit eaf1694. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 6adcf4a ♻️ This comment has been updated with latest results. |
# Pull Request <!--- Replace `#nnn` with your issue link for reference. --> Fixes insightsengineering/teal#1366 Related: - insightsengineering/teal#1382 - insightsengineering/teal.slice#622 - #340 ### Changes description - [x] Adds support for non-standard names in code dependency - [x] Support backtick symbols in code dependency <details> <summary>Reproducible code for backtick support in code parser</summary> `%add_column%` definition is not detected ```r pkgload::load_all("teal.data") #> ℹ Loading teal.data #> Loading required package: teal.code td <- teal_data() |> within({ IRIS <- iris IRIS2 <- iris MTCARS <- mtcars `%add_column%` <- function(lhs, rhs) dplyr::bind_cols(lhs, rhs) # @ add_column <- function(lhs, rhs) dplyr::bind_cols(lhs, rhs) IRIS <- IRIS %add_column% dplyr::tibble(yada = IRIS2$Species) IRIS <- add_column(IRIS, dplyr::tibble(yada2 = IRIS2$Species)) }) td |> get_code(datanames = "IRIS") |> cat() #> IRIS <- iris #> IRIS2 <- iris #> add_column <- function(lhs, rhs) dplyr::bind_cols(lhs, rhs) #> IRIS <- IRIS %add_column% dplyr::tibble(yada = IRIS2$Species) #> IRIS <- add_column(IRIS, dplyr::tibble(yada2 = IRIS2$Species)) td2 <- td |> within({ IRIS <- `%add_column%`(IRIS, dplyr::tibble(yada2 = IRIS2$Species)) }) td2 |> get_code(datanames = "IRIS") |> cat() #> IRIS <- iris #> IRIS2 <- iris #> add_column <- function(lhs, rhs) dplyr::bind_cols(lhs, rhs) #> IRIS <- IRIS %add_column% dplyr::tibble(yada = IRIS2$Species) #> IRIS <- add_column(IRIS, dplyr::tibble(yada2 = IRIS2$Species)) #> IRIS <- IRIS %add_column% dplyr::tibble(yada2 = IRIS2$Species) ``` <sup>Created on 2024-10-15 with [reprex v2.1.1](https://reprex.tidyverse.org)</sup> </details> --------- Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
# Pull Request Fixes insightsengineering/teal#1366 Related: - insightsengineering/teal#1382 - #622 - insightsengineering/teal.data#340 ### Changes description - Removed assertion on datanames that start with alphabetic character - [x] Fix problem with JS namespace in filter panel - [x] Fix crash when filtering using MAE (both SE and Matrix) - [x ] ~Fix upload of snapshot file that is not compatible~ - [x] Ignore datanames that contain functions, language, expression (and other non-data objects) - insightsengineering/teal#1352 --------- Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: Dawid Kałędkowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
wip
Pull Request
Fixes #1366
Related:
Changes description
.raw_data
is created and supports non-standard R names, such as:%pipe%
assigns<-