Fix the datanames bug causing teal app to crash when teal_data has non standard object names
#1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gogonzo
reviewed
Oct 8, 2024
| @@ -359,7 +359,9 @@ srv_teal_module.teal_module <- function(id, | |||
|
|
|||
| .resolve_module_datanames <- function(data, modules) { | |||
| stopifnot("data_rv must be teal_data object." = inherits(data, "teal_data")) | |||
| if (is.null(modules$datanames) || identical(modules$datanames, "all")) { | |||
| if (length(datanames(data))) { | |||
There was a problem hiding this comment.
I don't think this can be a first condition. If datanames are not null then other conditions will be ignored.
gogonzo
reviewed
Oct 8, 2024
R/utils.R
Outdated
| @@ -74,10 +74,13 @@ get_teal_bs_theme <- function() { | |||
| #' @param datanames (`character`) vector of data set names to include; must be subset of `datanames(x)` | |||
| #' @return A `FilteredData` object. | |||
| #' @keywords internal | |||
| teal_data_to_filtered_data <- function(x, datanames = ls(teal.code::get_env(x))) { | |||
| teal_data_to_filtered_data <- function(x, datanames = teal.data::datanames(data)) { | |||
There was a problem hiding this comment.
Maybe we can instead relax the assertion on datanames in teal.slice?
gogonzo
requested changes
Oct 8, 2024
Unit Tests Summary 1 files 25 suites 16m 33s ⏱️ For more details on these failures, see this check. Results for commit 0144176. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit d1b8670 ♻️ This comment has been updated with latest results. |
vedhav
force-pushed
the
1366-pass-proper-datanames@main
branch
from
e8e6a11 to
0144176
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1366