-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update required version of teal.logger #1349
update required version of teal.logger #1349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chlebowa !
Before we merge I just wanted to confirm if this is needed? |
Fair point @vedhav, I didn't test with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vedhav I think you're right.
The related PR in question is:
insightsengineering/teal.modules.general#760
@chlebowa can you confirm on your end?
Now that I have the latest |
In Are you also using the latest tmc (from main) when you get the error message? |
At the moment I am not getting the error emssage even using Sorry, I should have been more specific. If I had not updated |
This makes sense because the However, if you install Regardless, I will close this PR without merging since we already force this when using the teal modules. |
fixes #1348