Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update required version of teal.logger #1349

Conversation

chlebowa
Copy link
Contributor

fixes #1348

@donyunardi donyunardi enabled auto-merge (squash) September 23, 2024 15:06
Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chlebowa !

@vedhav vedhav disabled auto-merge September 23, 2024 15:12
@vedhav
Copy link
Contributor

vedhav commented Sep 23, 2024

Before we merge I just wanted to confirm if this is needed?
The teal.logger::log_shiny_input_changes is only used in module packages and teal does not use them.
The issue mentioned in this PR originates from the tmg and we already have the min version of teal.logger (>= 0.2.0.9004) in tmg which has the function log_shiny_input_changes exported.

@chlebowa
Copy link
Contributor Author

Fair point @vedhav, I didn't test with example_module(). Perhaps this fix belongs in module packages.

Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vedhav I think you're right.

The related PR in question is:
insightsengineering/teal.modules.general#760

@chlebowa can you confirm on your end?

@chlebowa
Copy link
Contributor Author

Now that I have the latest teal.logger installed, it doesn't matter which package forced it.
However, I'm afraid I will run into the same issue the next time I want to use tmc.

@donyunardi
Copy link
Contributor

However, I'm afraid I will run into the same issue the next time I want to use tmc.

In tmc we also forced the teal.logger to be >= 0.2.0.9004
https://github.com/insightsengineering/teal.modules.clinical/blob/1d4beec4ef14197445191b0957bb38e8bba9196d/DESCRIPTION#L60

Are you also using the latest tmc (from main) when you get the error message?

@chlebowa
Copy link
Contributor Author

chlebowa commented Sep 23, 2024

At the moment I am not getting the error emssage even using tmc v0.9.1 but, again, my teal.logger is already updated.

Sorry, I should have been more specific. If I had not updated teal.logger just now (I was not forced to do so by teal or any other package), I would get the same error. And if the issue is remedied in tmg only, tmc will be vulnerable.

@donyunardi
Copy link
Contributor

At the moment I am not getting the error emssage even using tmc v0.9.1 but, again, my teal.logger is already updated.

This makes sense because the teal.logger::log_shiny_input_changes in tmc was implemented after v0.9.1.

However, if you install tmc from main branch and you only have teal.logger 0.2.0, teal.logger would have been updated (or prompted for an update) since tmc requires teal.logger to be >= 0.2.0.9004.

Regardless, I will close this PR without merging since we already force this when using the teal modules.

@donyunardi donyunardi closed this Sep 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@chlebowa chlebowa deleted the 1348_bump_dependency_version@main branch September 24, 2024 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: critical bug
3 participants