Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1303 add a note to teal_data_module constructor's vignette #1336

Closed
wants to merge 5 commits into from
Closed

1303 add a note to teal_data_module constructor's vignette #1336

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54818e6
add a note to teal_data_module constructor in its vignette about how …
m7pr Aug 30, 2024
fe4f707
move the note between files
m7pr Sep 2, 2024
fcc5d38
Merge branch 'main' into 1303_documentation@main
m7pr Sep 18, 2024
a7b3610
Merge branch 'main' into 1303_documentation@main
m7pr Oct 3, 2024
4a6bbb1
Merge branch 'main' into 1303_documentation@main
m7pr Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions vignettes/data-as-shiny-module.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ if (interactive()) {

_See `?qenv` for a detailed explanation of how to use the `within` method._

Note: It is recommended to return `reactive()` `teal_data()` in `server` of `teal_data_module`
as this is more robust for maintaining the reactivity of Shiny. Try avoiding using `eventReactive()`, or make them react to `data()` at least. More in [this discussion](https://github.com/insightsengineering/teal/issues/1303#issuecomment-2286239832).

## Modification of data in-app

Another reason to postpone data operations is to involve the application user in the preprocessing stage.
Expand Down
Loading