Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config/Needs/verdepcheck cleanup; init() cleanup #1313

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Config/Needs/verdepcheck cleanup; init() cleanup #1313

merged 9 commits into from
Aug 14, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Aug 13, 2024

No description provided.

@pawelru pawelru requested a review from a team August 13, 2024 15:22
DESCRIPTION Show resolved Hide resolved
R/init.R Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Aug 13, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  49      11  77.55%   30, 32, 44, 55-62
R/get_rcode_utils.R                  12       0  100.00%
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                            112      52  53.57%   107-114, 163-172, 174, 186-207, 218, 236-239, 246-253, 256-257, 259
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     127  19.62%   47-68, 88-138, 143-144, 156, 203, 238-315
R/module_data_summary.R             191      68  64.40%   24-52, 94, 190, 230-270
R/module_filter_data.R               52       2  96.15%   22-23
R/module_filter_manager.R           230      57  75.22%   56-62, 73-82, 90-95, 108-112, 117-118, 291-314, 340, 367, 379, 386-387
R/module_init_data.R                108      11  89.81%   44-53, 67
R/module_nested_tabs.R              167      70  58.08%   33-121, 150, 200, 258, 297
R/module_snapshot_manager.R         216     146  32.41%   89-95, 104-113, 121-133, 152-153, 170-180, 184-199, 201-208, 215-230, 234-238, 240-246, 249-262, 265-273, 304-318, 321-332, 335-341, 355
R/module_teal_data.R                114      21  81.58%   42-48, 88-91, 115-124
R/module_teal_with_splash.R          12      12  0.00%    22-38
R/module_teal.R                     141      92  34.75%   43-146, 183-184, 192
R/module_transform_data.R            56      32  42.86%   17-51
R/modules.R                         162      21  87.04%   148-152, 207-210, 299-300, 352, 364-372
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 15       0  100.00%
R/teal_data_utils.R                  43       0  100.00%
R/teal_lockfile.R                    56      22  60.71%   34-38, 43-51, 72, 91, 94-102, 109
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/TealAppDriver.R                   353     353  0.00%    52-735
R/utils.R                           193       0  100.00%
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              12       8  33.33%   3-15
TOTAL                              2840    1230  56.69%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/init.R         +4      +4  -1.98%
TOTAL            +4      +4  -0.08%

Results for commit: 2f4d739

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Unit Tests Summary

  1 files   25 suites   9m 19s ⏱️
253 tests 247 ✅ 6 💤 0 ❌
528 runs  522 ✅ 6 💤 0 ❌

Results for commit 2f4d739.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💔 $40.79$ $+1.14$ $0$ $0$ $0$ $0$
shinytest2-data_summary 💚 $36.67$ $-31.64$ $0$ $+6$ $0$ $0$
shinytest2-filter_panel 💚 $41.27$ $-41.22$ $-2$ $+3$ $0$ $0$
shinytest2-init 💚 $26.54$ $-26.50$ $-14$ $+3$ $0$ $0$
shinytest2-landing_popup 💚 $43.13$ $-43.06$ $-6$ $+5$ $0$ $0$
shinytest2-module_bookmark_manager 💚 $34.41$ $-34.35$ $0$ $+4$ $0$ $0$
shinytest2-modules 💚 $37.45$ $-37.39$ $-1$ $+4$ $0$ $0$
shinytest2-reporter 💚 $70.18$ $-70.09$ $-3$ $+5$ $0$ $0$
shinytest2-show-rcode 💚 $10.61$ $-10.59$ $-8$ $+1$ $0$ $0$
shinytest2-teal_data_module 💚 $53.51$ $-53.44$ $-3$ $+6$ $0$ $0$
shinytest2-teal_slices 💚 $61.48$ $-61.45$ $-16$ $+2$ $0$ $0$
shinytest2-utils 💚 $10.41$ $-10.40$ $-3$ $+1$ $0$ $0$
shinytest2-wunder_bar 💚 $21.28$ $-21.25$ $-2$ $+2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-data_summary 💚 $8.76$ $-8.75$ e2e_data_summary_displays_datasets_by_datanames_order_if_no_join_keys
shinytest2-data_summary 💚 $3.52$ $-3.51$ e2e_data_summary_displays_datasets_by_topological_sort_of_join_keys
shinytest2-data_summary 💚 $13.96$ $-9.00$ e2e_data_summary_is_displayed_properly_if_teal_data_include_data.frames_with_join_keys_MAE_objects_and_vectors
shinytest2-data_summary 💚 $3.26$ $-3.24$ e2e_data_summary_is_displayed_with_2_columns_data_without_keys
shinytest2-data_summary 💚 $3.51$ $-3.50$ e2e_data_summary_is_displayed_with_3_columns_for_data_with_join_keys
shinytest2-data_summary 💚 $3.65$ $-3.65$ e2e_data_summary_list_only_data_names_if_there_is_no_MAE_or_data.frames_in_teal_data
shinytest2-filter_panel 💚 $15.60$ $-15.59$ e2e_filtering_a_module_specific_filter_is_not_refected_in_other_unshared_modules
shinytest2-filter_panel 💚 $15.63$ $-15.62$ e2e_filtering_a_module_specific_filter_is_reflected_in_other_shared_module
shinytest2-filter_panel 💚 $10.05$ $-10.02$ e2e_module_content_is_updated_when_a_data_is_filtered_in_filter_panel
shinytest2-init 💚 $8.04$ $-8.03$ e2e_init_creates_UI_containing_specified_title_favicon_header_and_footer
shinytest2-init 💚 $8.21$ $-8.19$ e2e_teal_app_initializes_with_no_errors
shinytest2-init 💚 $10.30$ $-10.28$ e2e_teal_app_initializes_with_sessionInfo_modal
shinytest2-landing_popup 💚 $8.23$ $-8.21$ e2e_app_with_customized_landing_popup_module_creates_modal_containing_specified_title_content_and_buttons
shinytest2-landing_popup 💚 $8.22$ $-8.20$ e2e_app_with_default_landing_popup_module_creates_modal_containing_a_button
shinytest2-landing_popup 💚 $8.05$ $-8.03$ e2e_teal_app_with_landing_popup_module_initializes_with_no_errors
shinytest2-landing_popup 💚 $8.10$ $-8.09$ e2e_when_customized_button_in_landing_popup_module_is_clicked_it_redirects_to_a_certain_page
shinytest2-landing_popup 💚 $10.54$ $-10.52$ e2e_when_default_landing_popup_module_is_closed_it_shows_the_underlying_teal_app
shinytest2-module_bookmark_manager 💚 $7.99$ $-7.97$ bookmark_manager_button_is_not_rendered_by_default
shinytest2-module_bookmark_manager 💚 $8.01$ $-7.99$ bookmark_manager_button_is_not_rendered_when_enableBookmarking_url_
shinytest2-module_bookmark_manager 💚 $8.03$ $-8.01$ bookmark_manager_button_is_rendered_when_enableBookmarking_server_
shinytest2-module_bookmark_manager 💚 $10.38$ $-10.37$ bookmark_manager_button_shows_modal_with_url_containing_state_id_when_clicked
shinytest2-modules 💚 $8.28$ $-8.26$ e2e_all_the_nested_teal_modules_are_initiated_as_expected
shinytest2-modules 💚 $9.95$ $-9.94$ e2e_filter_panel_only_shows_the_data_supplied_using_datanames
shinytest2-modules 💚 $10.04$ $-10.02$ e2e_filter_panel_shows_all_the_datasets_when_datanames_is_all
shinytest2-modules 💚 $9.18$ $-9.16$ e2e_the_module_server_logic_is_only_triggered_when_the_teal_module_becomes_active
shinytest2-reporter 💚 $17.91$ $-17.89$ e2e_adding_a_report_card_in_a_module_adds_it_in_the_report_previewer_tab
shinytest2-reporter 💚 $21.12$ $-21.10$ e2e_reporter_does_not_show_the_secondary_column_that_shows_filter_panel
shinytest2-reporter 💚 $14.49$ $-14.47$ e2e_reporter_previewer_module_do_not_show_data_summary_nor_filter_panel
shinytest2-reporter 💚 $8.62$ $-8.61$ e2e_reporter_tab_is_created_when_a_module_has_reporter
shinytest2-reporter 💚 $8.04$ $-8.02$ e2e_reporter_tab_is_not_created_when_a_module_has_no_reporter
shinytest2-show-rcode 💚 $10.61$ $-10.59$ e2e_teal_app_initializes_with_Show_R_Code_modal
shinytest2-teal_data_module 💚 $10.73$ $-10.72$ e2e_teal_data_module_gets_removed_after_successful_data_load_when_once_TRUE
shinytest2-teal_data_module 💚 $13.14$ $-13.13$ e2e_teal_data_module_inputs_change_teal_data_object_that_is_passed_to_teal_main_UI
shinytest2-teal_data_module 💚 $7.55$ $-7.54$ e2e_teal_data_module_is_still_visible_after_successful_data_load_when_once_FALSE
shinytest2-teal_data_module 💚 $5.30$ $-5.29$ e2e_teal_data_module_shows_validation_errors
shinytest2-teal_data_module 💚 $10.85$ $-10.84$ e2e_teal_data_module_will_have_a_delayed_load_of_datasets
shinytest2-teal_data_module 💚 $5.94$ $-5.92$ e2e_teal_data_module_will_make_other_tabs_inactive_before_successful_data_load
shinytest2-teal_slices 💚 $23.38$ $-23.36$ e2e_teal_slices_filters_are_initialized_when_global_filters_are_created
shinytest2-teal_slices 💚 $38.10$ $-38.09$ e2e_teal_slices_filters_are_initialized_when_module_specific_filters_are_created
shinytest2-utils 💚 $10.41$ $-10.40$ e2e_show_hide_hamburger_works_as_expected
shinytest2-wunder_bar 💚 $10.82$ $-10.81$ wunder_bar_srv_clicking_filter_icon_opens_filter_manager_modal
shinytest2-wunder_bar 💚 $10.46$ $-10.45$ wunder_bar_srv_clicking_snapshot_icon_opens_snapshot_manager_modal

Results for commit 9323fb1

♻️ This comment has been updated with latest results.

R/init.R Outdated Show resolved Hide resolved
R/init.R Outdated Show resolved Hide resolved
R/init.R Show resolved Hide resolved
R/init.R Outdated Show resolved Hide resolved
R/init.R Outdated Show resolved Hide resolved
R/init.R Outdated Show resolved Hide resolved
pawelru and others added 2 commits August 14, 2024 12:50
@pawelru pawelru enabled auto-merge (squash) August 14, 2024 11:24
@pawelru pawelru merged commit 24678ff into main Aug 14, 2024
28 checks passed
@pawelru pawelru deleted the init_cleanup branch August 14, 2024 13:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants