use topological_sort for summary table datasets
#1277
Conversation
| ordered_datanames <- intersect(ordered_datanames, datanames) | ||
|
|
||
| rows <- lapply( | ||
| ordered_datanames, |
There was a problem hiding this comment.
I'd apply this to teal_data_datanames function so that we keep this order consistent in whole teal application.
There was a problem hiding this comment.
@gogonzo do you mean teal.data::datanames() ? https://github.com/insightsengineering/teal.data/blob/main/R/teal_data-datanames.R#L34
Sure, that would make sense. So each time datanames(teal_data) is called we already get names in the topological sort order. So let's abandon this branch and I'll provide a PR in teal.data
There was a problem hiding this comment.
I mean teal:::teal_data_datanames
There was a problem hiding this comment.
Created a small PR in teal.data package. Still WIP. Asked @averissimo for the review insightsengineering/teal.data#318
There was a problem hiding this comment.
ignore my PR, I will investigate teal:::teal_data_datanames
|
Closing in favour of #1280 |
Part of #1253