-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend TealAppDriver$active_module_element()
method with new hash
parameter
#1150
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d93a8c9
Empty-Commit
m7pr 96f8027
tests for teal.widgets::verbatim_popup
m7pr e86175e
add info about a detected issue
m7pr 50e0ba3
skeleton for table_with_settings shinytest2 tests
m7pr ba4959c
wip - testing buttons
m7pr 679ae26
test reviewing buttons of the table
m7pr c94490f
use $active_module_element instead of print
m7pr 3414184
typo
m7pr c0cb560
add button clicks
m7pr 6e168f9
change test name for table_with_settings
m7pr 8d0cfd2
Merge branch 'main' into teal.widgets@503-introduce-shinytest2@main
m7pr d8407df
include features from other PRs
m7pr 4cc61a6
finalize tests for teal.widgets::table_with_settings
m7pr cd25ffb
[skip style] [skip vbump] Restyle files
github-actions[bot] f4c7557
Merge branch 'main' into teal.widgets@503-introduce-shinytest2@main
m7pr 1cb56fd
Update tests/testthat/test-shinytest2-teal-widgets.R
m7pr ff4b223
remove comments
m7pr f002f46
reduce pagination selector
m7pr 9f09704
extract input value for the download button
m7pr c98585d
[skip style] [skip vbump] Restyle files
github-actions[bot] bece513
checking the visibility. ugh
m7pr 028dafb
Merge branch 'teal.widgets@503-introduce-shinytest2@main' of https://…
m7pr ee7e898
Merge branch 'main' into teal.widgets@503-introduce-shinytest2@main
m7pr 9a23c3c
move test to teal.widgets repository
m7pr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide use case where id is needed without a
#
prefix?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gogonzo yes, it is for the download button of the table in
table_with_settings
insightsengineering/teal.widgets@aba6883#diff-62f05f4a2946a28d82c9a50384d362f9c47e6af156367fb8a9bc485bf1bb2f32R155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the
app$get_value()
that doesn't take#
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but teal.widgets don't use tealAppDriver so I think it isn't necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I've never experience a need to remove hash anywhere else in any other test