Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

503 shinytest2 for teal_data_module #1148

Merged
merged 13 commits into from
Mar 20, 2024
Merged

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Mar 12, 2024

Pull Request

Part of https://github.com/insightsengineering/coredev-tasks/issues/503

Changes description

  • Adds tests for teal_data_module
    1. Loads iris and mtcars
    2. Fails to load teal app if required input is not available
    3. Integrates input on teal_data() object by creating a new dynamic column

@averissimo averissimo changed the title e2e adds teal_data_module tests 503 shinytest2 for teal_data_module Mar 12, 2024
Copy link
Contributor

github-actions bot commented Mar 12, 2024

Unit Tests Summary

  1 files   27 suites   1m 37s ⏱️
229 tests 229 ✅ 0 💤 0 ❌
486 runs  486 ✅ 0 💤 0 ❌

Results for commit 7a0d90d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 12, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-teal_data_module 👶 $+9.65$ $+4$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-teal_data_module 👶 $+4.02$ e2e_teal_data_module_inputs_change_teal_data_object_that_is_passed_to_teal_main_UI
shinytest2-teal_data_module 👶 $+2.30$ e2e_teal_data_module_shows_validation_errors
shinytest2-teal_data_module 👶 $+3.33$ e2e_teal_data_module_will_have_a_delayed_load_of_datasets

Results for commit 8a70054

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 13, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  30       0  100.00%
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22       0  100.00%
R/init.R                             86      25  70.93%   108-115, 161-162, 164, 179-185, 192-197, 228
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_filter_manager.R           107      16  85.05%   50-58, 67-72, 207
R/module_nested_tabs.R              154       3  98.05%   47, 128, 228
R/module_snapshot_manager.R         209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 343-366
R/module_tabs_with_filters.R         76       0  100.00%
R/module_teal_with_splash.R         114       1  99.12%   110
R/module_teal.R                     106       1  99.06%   57
R/modules.R                         152      23  84.87%   127-130, 147-151, 206-209, 291-292, 344, 356-364
R/reporter_previewer_module.R        18       0  100.00%
R/show_rcode_modal.R                 19      19  0.00%    17-36
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    62       5  91.94%   69, 118-119, 122, 139
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59       0  100.00%
R/TealAppDriver.R                   225      55  75.56%   66-69, 124-127, 135, 156-157, 177-178, 200-206, 314-339, 389-397, 401, 419, 452
R/utils.R                           173       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              12       8  33.33%   3-15
TOTAL                              1892     378  80.02%

Diff against main

Filename                       Stmts    Miss  Cover
---------------------------  -------  ------  -------
R/module_filter_manager.R          0     -13  +12.15%
R/module_teal_with_splash.R        0      -1  +0.88%
R/teal_slices.R                    0     -12  +20.34%
R/TealAppDriver.R                  0     -16  +7.11%
TOTAL                              0     -42  +2.22%

Results for commit: 7a0d90d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@vedhav vedhav self-assigned this Mar 18, 2024
Base automatically changed from 503-introduce-shinytest2@main to main March 18, 2024 12:05
@averissimo averissimo changed the base branch from main to 503-introduce-shinytest2@main March 18, 2024 13:03
@averissimo averissimo force-pushed the tdm@503-introduce-shinytest2@main branch from 2f27c69 to 638bdf2 Compare March 18, 2024 13:09
@averissimo averissimo changed the base branch from 503-introduce-shinytest2@main to main March 18, 2024 13:09
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@averissimo averissimo enabled auto-merge (squash) March 20, 2024 14:37
@averissimo averissimo disabled auto-merge March 20, 2024 14:37
…nytest2@main

* origin/main:
  [skip actions] Bump version to 0.15.2.9011
  register teal.logger handlers; replace few loggers with base (#1081)
  [skip actions] Bump version to 0.15.2.9010
  503 shinytest2 fixes bug with setting numeric range (#1152)
  [skip actions] Bump version to 0.15.2.9009
  `$active_module_element_text` method `TealAppDriver` (#1167)
@averissimo averissimo merged commit 443319f into main Mar 20, 2024
21 checks passed
@averissimo averissimo deleted the tdm@503-introduce-shinytest2@main branch March 20, 2024 15:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants