503 shinytest2 for Show R code modal

[m7pr]

Part of https://github.com/insightsengineering/coredev-tasks/issues/503

[github-actions]

Unit Tests Summary

  1 files   26 suites   1m 30s ⏱️
226 tests 226 ✅ 0 💤 0 ❌
483 runs  483 ✅ 0 💤 0 ❌

Results for commit a9c118f.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-show-rcode	👶		$+3.84$	$+9$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-show-rcode	👶		$+3.84$	e2e_teal_app_initializes_with_Show_R_Code_modal

Results for commit dfafb4d

♻️ This comment has been updated with latest results.

[m7pr]

  testthat::expect_equal(
    app$get_text("#shiny-modal > div > div > div.modal-header > h4"),
    "Example Code"
  )

is failing but I don't have that issue when running the test locally ...

[vedhav]

  testthat::expect_equal(
    app$get_text("#shiny-modal > div > div > div.modal-header > h4"),
    "Example Code"
  )

is failing but I don't have that issue when running the test locally ...

It's failing for me. Let me try to debug.

[m7pr]

It's failing when I run the test but when I run the code inside the test, line by line it does not break.

[vedhav]

Perhaps we need to wait after the click app$click(selector = button_selector)
Interactively there is a delay so it passes.

[vedhav]

Yeah, adding app$wait_for_idle(timeout = default_idle_timeout) after the click solves it!

[m7pr]

aaaah, thanks! will push

[github-actions]

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  30       0  100.00%
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22       0  100.00%
R/init.R                             86      25  70.93%   108-115, 161-162, 164, 179-185, 192-197, 228
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_filter_manager.R           107      29  72.90%   50-58, 67-72, 195, 200-213
R/module_nested_tabs.R              154       3  98.05%   47, 128, 228
R/module_snapshot_manager.R         209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 343-366
R/module_tabs_with_filters.R         76       0  100.00%
R/module_teal_with_splash.R         114       2  98.25%   110, 131
R/module_teal.R                     106       1  99.06%   57
R/modules.R                         153      24  84.31%   127-130, 147-151, 206-210, 292-293, 345, 357-365
R/reporter_previewer_module.R        18       0  100.00%
R/show_rcode_modal.R                 19      19  0.00%    17-36
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    62       5  91.94%   69, 118-119, 122, 139
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/TealAppDriver.R                   195      59  69.74%   66-77, 124-127, 135, 155, 167-168, 190-196, 278-325, 369, 402
R/utils.R                           173       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              11       7  36.36%   3-14
TOTAL                              1862     408  78.09%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  -------
R/TealAppDriver.R        0      -2  +1.03%
TOTAL                    0      -2  +0.11%

Results for commit: a9c118f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[averissimo]

(edit)
🤔 How about placing this on a different test file? It's only 2 tests but it might help to organize tests

(original)
One more spec hits the dust!! Nice job!

🔍 I think we shouldn't be overly specific on the selector rules. Allowing for some flexibility on changes from how shiny creates modals.

That is, we may skip those intermediate div containers as that's not relevant to our test #id > div > div > div.modal-header > h4

Made some suggestions to avoid the child selector, using data-dismiss attribute instead. Let's discuss if there is a better way or if we should also search for the attribute's value

[m7pr]

Hey @averissimo thanks for the review! I tried to apply comments from this PR, and the other one about Session Info.

About this

How about placing this on a different test file? It's only 2 tests but it might help to organize tests

This actually checks verbatim_popup that is used by example_module. This does not test R/show_rcode_modal which is not used anymore. I could suggest we name the new file as tests/test-shinytest2-show-rcode.R but I hope it's not gonna be confusing with R/show_rcode_modal that I think we could completely remove #1154

[m7pr]

moved the test to a separate file

[m7pr]

Hey @averissimo I applied changes on this PR and used methods ($active_module_element) that we created in other PRs.
I think this simple PR is ready to be merged.

[averissimo]

Awesome!