Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the check status to the main teal_data function call #1070

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Jan 25, 2024

Part of #1069

Please make sure that you also use the teal.data branch 1069-fix-code-warnings-when-data-is-verified@main for testing the example from the issue.

@vedhav vedhav added bug Something isn't working core labels Jan 25, 2024
Copy link
Contributor

github-actions bot commented Jan 25, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  97      88  9.28%    9-71, 93-106, 109-116, 131-146
R/get_rcode_utils.R                  32       1  96.88%   52
R/include_css_js.R                   24       0  100.00%
R/init.R                             96      31  67.71%   113-120, 177-178, 180, 192-213, 244-245, 247
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_filter_manager.R           107      36  66.36%   49-55, 62-70, 79-84, 228, 233-246
R/module_nested_tabs.R              151      58  61.59%   65-138, 154, 206, 228, 254
R/module_snapshot_manager.R         209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 346-369
R/module_tabs_with_filters.R         73      33  54.79%   60-95, 127, 140
R/module_teal_with_splash.R         114       4  96.49%   87, 108, 174-175
R/module_teal.R                     141      33  76.60%   72, 83, 92, 166-167, 173, 204, 212-213, 235-267
R/modules_debugging.R                19      19  0.00%    25-45
R/modules.R                         151      33  78.15%   119, 131-139, 224-227, 244-248, 303-307, 397-440
R/reporter_previewer_module.R        18       2  88.89%   26, 30
R/show_rcode_modal.R                 20      20  0.00%    16-37
R/tdata.R                            53       1  98.11%   153
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    60       5  91.67%   65, 116-117, 120, 137
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   135-148
R/utils.R                           142      28  80.28%   113-140, 297
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   109-371
R/zzz.R                              11       7  36.36%   3-14
TOTAL                              1761     630  64.22%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  -------
R/module_nested_tabs.R       +2       0  +0.52%
R/utils.R                    +1       0  +0.14%
TOTAL                        +3       0  +0.06%

Results for commit: b3432fa

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Unit Tests Summary

  1 files   19 suites   10s ⏱️
204 tests 202 ✅ 2 💤 0 ❌
421 runs  418 ✅ 3 💤 0 ❌

Results for commit b3432fa.

♻️ This comment has been updated with latest results.

R/module_nested_tabs.R Outdated Show resolved Hide resolved
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment below

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vedhav vedhav enabled auto-merge (squash) January 25, 2024 07:56
@vedhav vedhav merged commit ba14515 into main Jan 25, 2024
23 checks passed
@vedhav vedhav deleted the 1069-fix-code-warnings-when-data-is-verified@main branch January 25, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The verification status of the teal_data object is lost making all data to be unverified
3 participants