-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-release activities #1021
Merged
Merged
Pre-release activities #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Summary
Diff against main
Results for commit: 309e581 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 19 suites 10s ⏱️ Results for commit 309e581. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 31b599f ♻️ This comment has been updated with latest results. |
chlebowa
suggested changes
Jan 8, 2024
4 tasks
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: Aleksander Chlebowski <[email protected]>
Co-authored-by: Vedha Viyash <[email protected]> Signed-off-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: Aleksander Chlebowski <[email protected]>
Signed-off-by: Aleksander Chlebowski <[email protected]>
chlebowa
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of insightsengineering/nestdevs-tasks#48
- README.md (check example code)
- NEWS.md
- @example tag, make sure it runs, fix if otherwise
- Make sure functions has @return tag to document the return value
- no \dontrun tag, replace with if(interactive()) if needed