register teal.logger handlers; replace few loggers with base (#1081)

close insightsengineering/coredev-tasks#502
test with insightsengineering/teal.logger#73

I will keep it as a draft for the time being because this requires
(currently) development version of `teal.logger`. This has impact on our
release plan as `teal.logger` would have to be released first

---------

Signed-off-by: Pawel Rucki <[email protected]>

DESCRIPTION

@@ -50,7 +50,7 @@ Imports:
     shinyjs,
     stats,
     teal.code (>= 0.5.0),
-    teal.logger (>= 0.1.1),
+    teal.logger (>= 0.1.3.9013),
     teal.reporter (>= 0.2.0),
     teal.widgets (>= 0.4.0),
     utils

R/landing_popup_module.R

@@ -66,7 +66,7 @@ landing_popup_module <- function(label = "Landing Popup",
   )
   checkmate::assert_multi_class(buttons, classes = c("shiny.tag", "shiny.tag.list"))
 
-  logger::log_info("Initializing landing_popup_module")
+  message("Initializing landing_popup_module")
 
   module <- module(
     label = label,

R/modules.R

@@ -206,7 +206,6 @@ module <- function(label = "module",
     datanames <- filters
     msg <-
       "The `filters` argument is deprecated and will be removed in the next release. Please use `datanames` instead."
-    logger::log_warn(msg)
     warning(msg)
   }
 

R/reporter_previewer_module.R

@@ -24,7 +24,7 @@ reporter_previewer_module <- function(label = "Report previewer", server_args =
   checkmate::assert_list(server_args, names = "named")
   checkmate::assert_true(all(names(server_args) %in% names(formals(teal.reporter::reporter_previewer_srv))))
 
-  logger::log_info("Initializing reporter_previewer_module")
+  message("Initializing reporter_previewer_module")
 
   srv <- function(id, reporter, ...) {
     teal.reporter::reporter_previewer_srv(id, reporter, ...)

R/zzz.R

@@ -10,6 +10,7 @@
 
   # Set up the teal logger instance
   teal.logger::register_logger("teal")
+  teal.logger::register_handlers("teal")
 
   invisible()
 }

tests/testthat/setup-logger.R

@@ -1 +1 @@
-logger::log_appender(function(...) {}, namespace = "teal")
+logger::log_appender(function(...) NULL, namespace = "teal")