Remove TealData checks (#1406)

# Pull Request Fixes #1386 Removes TealData checks from the code base --------- Signed-off-by: Lluís Revilla <[email protected]> Co-authored-by: Marcin <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dawid Kałędkowski <[email protected]>
insightsengineering · Nov 15, 2024 · 1767e03 · 1767e03
1 parent d9fb47d
commit 1767e03
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 14 deletions.
diff --git a/R/init.R b/R/init.R
@@ -103,16 +103,6 @@ init <- function(data,
 
   # argument checking (independent)
   ## `data`
-  if (inherits(data, "TealData")) {
-    lifecycle::deprecate_stop(
-      when = "0.15.0",
-      what = "init(data)",
-      paste(
-        "TealData is no longer supported. Use teal_data() instead.",
-        "Please follow migration instructions https://github.com/insightsengineering/teal/discussions/988."
-      )
-    )
-  }
   checkmate::assert_multi_class(data, c("teal_data", "teal_data_module"))
   checkmate::assert_class(landing_popup, "teal_module_landing", null.ok = TRUE)
 

diff --git a/R/modules.R b/R/modules.R
@@ -196,6 +196,7 @@ module <- function(label = "module",
       "\n - `...` server_args elements will be passed to the module named argument or to the `...`"
     )
   }
+
   if ("datasets" %in% server_formals) {
     warning(
       sprintf("Called from module(label = \"%s\", ...)\n  ", label),
@@ -205,7 +206,6 @@ module <- function(label = "module",
     )
   }
 
-
   ## UI
   checkmate::assert_function(ui)
   ui_formals <- names(formals(ui))
@@ -217,6 +217,7 @@ module <- function(label = "module",
       "\n - `...` ui_args elements will be passed to the module argument of the same name or to the `...`"
     )
   }
+
   if (any(c("data", "datasets") %in% ui_formals)) {
     stop(
       sprintf("Called from module(label = \"%s\", ...)\n  ", label),
@@ -226,7 +227,6 @@ module <- function(label = "module",
     )
   }
 
-
   ## `filters`
   if (!missing(filters)) {
     datanames <- filters

diff --git a/man/teal_data_module.Rd b/man/teal_data_module.Rd
diff --git a/tests/testthat/test-modules.R b/tests/testthat/test-modules.R
@@ -31,7 +31,6 @@ testthat::test_that("module warns when server contains datasets argument", {
   )
 })
 
-
 testthat::test_that("module expects server being a shiny server module with any argument", {
   testthat::expect_no_error(module(server = function(id) NULL))
-Original file line number
+Diff line change
@@ Expand Up @@
       )
     })
     testthat::test_that("module expects server being a shiny server module with any argument", {
       testthat::expect_no_error(module(server = function(id) NULL))
@@ Expand Down @@