Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

445 unify html tags #230

Merged
merged 3 commits into from
Mar 14, 2024
Merged

445 unify html tags #230

merged 3 commits into from
Mar 14, 2024

Conversation

kartikeyakirar
Copy link
Contributor

part of insightsengineering/teal.slice#445
for teal.widget package

Copy link
Contributor

github-actions bot commented Mar 7, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            82      82  0.00%    57-152
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/include_css_js.R                7       1  85.71%   17
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   149-447, 501, 554, 560, 575-588
R/panel_group.R                  90      90  0.00%    50-190
R/plot_with_settings.R          382      21  94.50%   294-307, 366-367, 378-379, 653-654, 656, 658
R/standard_layout.R              35       0  100.00%
R/table_with_settings.R         173       1  99.42%   85
R/utils.R                        14       1  92.86%   7
R/verbatim_popup.R               99      49  50.51%   64-79, 105-106, 108, 116-144, 165
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1245     493  60.40%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 74c5432

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Unit Tests Summary

  1 files   10 suites   13s ⏱️
101 tests 101 ✅ 0 💤 0 ❌
208 runs  208 ✅ 0 💤 0 ❌

Results for commit 74c5432.

♻️ This comment has been updated with latest results.

@averissimo averissimo self-assigned this Mar 14, 2024
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Please check 74c5432 before merging as I found a couple missing tags

@kartikeyakirar kartikeyakirar merged commit 3b574e5 into main Mar 14, 2024
24 checks passed
@kartikeyakirar kartikeyakirar deleted the 445_unify_tags branch March 14, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants