-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
149 revise documentation #226
Conversation
Hey @donyunardi I prepared few improvements for #149. Some comments were outdated, so please check comments in #149 to see what was omitted. While going through this issue I noticed we could do
At the end of the day I think this was a weird issue, since we tried to provide examples for a lot of utility functions that are used outside of the package to build tmg and tmc modules and encodings panel. So it was hard to create condensed examples, that would focus only on a specific function, which comes with a lot of other functions. Separately some functions just are out of context and do not have much sense. Maybe we should create an extra vignette covering those? |
Code Coverage Summary
Diff against main
Results for commit: 126888e Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 10 suites 14s ⏱️ Results for commit 126888e. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @m7pr!
Just small comments and this is good to go!
Co-authored-by: Dony Unardi <[email protected]> Signed-off-by: Marcin <[email protected]>
…ineering/teal.widgets into 149_revise_docs@main
Changes incorporated @donyunardi . Take a look, when you have some spare time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
And thanks for creating new issue about the panel widget so we can move forward with this PR.
Close #149