Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the example apps #219

Merged
merged 11 commits into from
Jan 30, 2024
Merged

fixing the example apps #219

merged 11 commits into from
Jan 30, 2024

Conversation

kartikeyakirar
Copy link
Contributor

this fixes : #215

Copy link
Contributor

github-actions bot commented Jan 29, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            82      82  0.00%    57-152
R/get_dt_rows.R                  13      13  0.00%    43-55
R/ggplot2_args.R                 49       0  100.00%
R/include_css_js.R                7       1  85.71%   17
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   149-447, 501, 554, 560, 575-588
R/panel_group.R                  90      90  0.00%    12-132
R/plot_with_settings.R          382      21  94.50%   293-306, 365-366, 377-378, 628-629, 631, 633
R/standard_layout.R              35       0  100.00%
R/table_with_settings.R         173       1  99.42%   84
R/utils.R                        14       1  92.86%   7
R/verbatim_popup.R               99      49  50.51%   64-79, 105-106, 108, 116-144, 165
R/white_small_well.R              7       7  0.00%    18-24
TOTAL                          1245     493  60.40%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 729ef48

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@averissimo averissimo self-assigned this Jan 30, 2024
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change the remaining shinyApp(ui$... call?

  • plot_with_settings_srv

Otherwise it LGTM. A small comment about some code that can be compacted, but nothing else

checks also run without problems locally

  • All examples run manually and via devtools::run_examples(fresh = T)
  • Vignette examples also run without a problem

R/optionalInput.R Outdated Show resolved Hide resolved
@kartikeyakirar
Copy link
Contributor Author

Can you also change the remaining shinyApp(ui$... call?

thanks @averissimo, I missed that example. updated here 798aa37

Copy link
Contributor

Unit Tests Summary

  1 files   10 suites   13s ⏱️
101 tests 101 ✅ 0 💤 0 ❌
208 runs  208 ✅ 0 💤 0 ❌

Results for commit 729ef48.

Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

  • Tested all examples manually and via devtools::{run_examples,check} and they work fine
  • No shiny:: prefix in examples

@kartikeyakirar kartikeyakirar merged commit b0cd582 into main Jan 30, 2024
24 checks passed
@kartikeyakirar kartikeyakirar deleted the 215_fix_app_init branch January 30, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: example shiny app initialization issues
2 participants