-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing the example apps #219
Conversation
Code Coverage Summary
Diff against main
Results for commit: 729ef48 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also change the remaining shinyApp(ui$...
call?
plot_with_settings_srv
Otherwise it LGTM. A small comment about some code that can be compacted, but nothing else
checks
also run without problems locally
- All examples run manually and via
devtools::run_examples(fresh = T)
- Vignette examples also run without a problem
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
…ring/teal.widgets into 215_fix_app_init
thanks @averissimo, I missed that example. updated here 798aa37 |
Unit Tests Summary 1 files 10 suites 13s ⏱️ Results for commit 729ef48. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
- Tested all examples manually and via
devtools::{run_examples,check}
and they work fine - No
shiny::
prefix in examples
this fixes : #215