Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DESCRIPTION before CRAN release #193

Merged
merged 7 commits into from
Sep 29, 2023
Merged

Update DESCRIPTION before CRAN release #193

merged 7 commits into from
Sep 29, 2023

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Sep 27, 2023

Continuation of #191 and a part of #189

@m7pr m7pr added the core label Sep 27, 2023
@m7pr m7pr requested a review from donyunardi September 27, 2023 11:16
@m7pr m7pr mentioned this pull request Sep 27, 2023
32 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  --------------------------------------------
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         82      82  0.00%    57-152
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       1  85.71%   17
R/optionalInput.R            225     182  19.11%   87-351, 403, 454, 460, 475-488
R/panel_group.R               90      90  0.00%    12-132
R/plot_with_settings.R       382      21  94.50%   272-285, 344-345, 356-357, 607-608, 610, 612
R/standard_layout.R           35       0  100.00%
R/table_with_settings.R      173       1  99.42%   79
R/utils.R                     11       1  90.91%   7
R/verbatim_popup.R            99      49  50.51%   63-78, 104-105, 107, 115-143, 164
R/white_small_well.R           7       7  0.00%    18-24
TOTAL                       1196     447  62.63%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 137c49b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Unit Tests Summary

    1 files    10 suites   18s ⏱️
101 tests 101 ✔️ 0 💤 0
208 runs  208 ✔️ 0 💤 0

Results for commit cee980c.

♻️ This comment has been updated with latest results.

@averissimo
Copy link
Contributor

Wanna sneak in the update on the installation instructions on this PR? 😄

diff --git a/README.md b/README.md
index b3fd153..93b72d6 100644
--- a/README.md
+++ b/README.md
@@ -36,7 +36,7 @@ This package provides various widgets for `teal` applications. Examples include:
 
 ```r
 # stable versions
-install.packages('teal.widgets', repos = c('https://insightsengineering.r-universe.dev', getOption('repos')))
+install.packages('teal.widgets')
 
 # install.packages("pak")
 pak::pak("insightsengineering/teal.widgets@*release")

@m7pr
Copy link
Contributor Author

m7pr commented Sep 28, 2023

@averissimo I did cross installation instructions : ) let's change them the moment the package lands on CRAN. This might take a couple more days (weeks) so let's leave installation as it is

@m7pr m7pr enabled auto-merge (squash) September 29, 2023 09:44
@m7pr m7pr merged commit 9d777ac into main Sep 29, 2023
22 checks passed
@m7pr m7pr deleted the readme@main branch September 29, 2023 09:48
@averissimo
Copy link
Contributor

I just noticed that the side effect is that the README link on CRAN still has the r-universe way of installing :-\ https://cran.r-project.org/web/packages/teal.widgets/readme/README.html

It's not a big deal though as it will eventually be updated

@m7pr
Copy link
Contributor Author

m7pr commented Oct 16, 2023

Oh yeah, I think the final version pushed to CRAN should have that changed manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants