Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for teal.slice #73

Merged
merged 6 commits into from
Jun 22, 2022
Merged

Conversation

nikolas-burkoff
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff commented Jun 15, 2022

@nikolas-burkoff nikolas-burkoff marked this pull request as ready for review June 15, 2022 12:40
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------------------------------------------------------------------
R/all_choices.R                       1       0  100.00%
R/call_utils.R                      156     124  20.51%   14-23, 64, 66, 68, 107-431
R/check_selector.R                   31       0  100.00%
R/choices_labeled.R                 202      61  69.80%   60, 71, 76, 87, 103, 221-225, 229-234, 264-277, 390-391, 393, 425-473
R/choices_selected.R                 81      11  86.42%   201-229, 260
R/column_functions.R                  3       3  0.00%    13-16
R/data_extract_datanames.R           32       8  75.00%   9-13, 64-66
R/data_extract_filter_module.R       91      32  64.84%   68-81, 83, 86-87, 89-105, 142
R/data_extract_module.R             205      20  90.24%   3, 121, 126, 143, 146-151, 153, 172-175, 222, 355, 360, 392, 398
R/data_extract_read_module.R        121      13  89.26%   27, 31-34, 101-106, 115, 132
R/data_extract_select_module.R       32      18  43.75%   31-48
R/data_extract_single_module.R       53       2  96.23%   29, 42
R/data_extract_spec.R                32       0  100.00%
R/data_merge_module.R                44      19  56.82%   101-122
R/filter_spec.R                     186       1  99.46%   373
R/format_data_extract.R              16       1  93.75%   49
R/get_dplyr_call.R                  298       0  100.00%
R/get_merge_call.R                  283      32  88.69%   29-36, 47, 210-219, 362, 369, 385-397, 460
R/include_css_js.R                    5       0  100.00%
R/input_checks.R                     11       2  81.82%   18-19
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  154       7  95.45%   71, 123, 251-255
R/resolve_delayed.R                 104      44  57.69%   223-306
R/select_spec.R                      49       8  83.67%   149, 213-220
R/utils.R                            15      11  26.67%   26-39
R/zzz.R                               2       2  0.00%    2-3
TOTAL                              2209     419  81.03%

Results for commit: b0cea59

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Nikolas Burkoff added 3 commits June 15, 2022 13:51
@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    20 suites   35s ⏱️
146 tests 145 ✔️ 1 💤 0
543 runs  542 ✔️ 1 💤 0

Results for commit 9e12a2d.

@@ -280,8 +285,7 @@ data <- teal.data::cdisc_data(
teal.data::cdisc_dataset("ADTTE", adtte)
)

ds <- teal.slice:::CDISCFilteredData$new()
isolate(teal.slice:::filtered_data_set(data, ds))
ds <- teal.slice::init_filtered_data(data)
Copy link
Contributor

@kpagacz kpagacz Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that isolate was needed before, but it is not now. Not saying there is something wrong with it, just musing over possible performance implications.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked on main - wasn't needed before also

@kpagacz kpagacz self-assigned this Jun 21, 2022
@nikolas-burkoff nikolas-burkoff merged commit fc44939 into main Jun 22, 2022
@nikolas-burkoff nikolas-burkoff deleted the 33_filteredData_constructor@main branch June 22, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants