-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for teal.slice #73
Conversation
Code Coverage Summary
Results for commit: b0cea59 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
@@ -280,8 +285,7 @@ data <- teal.data::cdisc_data( | |||
teal.data::cdisc_dataset("ADTTE", adtte) | |||
) | |||
|
|||
ds <- teal.slice:::CDISCFilteredData$new() | |||
isolate(teal.slice:::filtered_data_set(data, ds)) | |||
ds <- teal.slice::init_filtered_data(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that isolate was needed before, but it is not now. Not saying there is something wrong with it, just musing over possible performance implications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked on main - wasn't needed before also
Part of insightsengineering/teal.slice#33 requires insightsengineering/teal.slice#49