-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
229 delayed_choices
as single function
#231
Open
chlebowa
wants to merge
9
commits into
insightsengineering:main
Choose a base branch
from
chlebowa:229_delayed_choices@main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
229 delayed_choices
as single function
#231
chlebowa
wants to merge
9
commits into
insightsengineering:main
from
chlebowa:229_delayed_choices@main
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
chlebowa
force-pushed
the
229_delayed_choices@main
branch
from
December 18, 2024 20:44
5d17ca7
to
d89ee0c
Compare
chlebowa
force-pushed
the
229_delayed_choices@main
branch
from
December 19, 2024 15:24
d89ee0c
to
268e3d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #229
CHANGES
Replaced
all_choices
withdelayed_choices
which allows to perform delayed selection of the first or the last element ofchoices
, as well as all elements, maintainingall_choices
functionality.IMPLEMENTATION
delayed_choices
returns a function that will add the appropriate subsetting operation to the function found in the$subset
element of itsdelayed_data
argument. Atomic arguments are returned as is.The function has a class for easy identification.
Selecting all choices (
delayed_choices("all")
) is still a special case when checking arguments in some functions (choices
vsmultiple
) so an extra class is added todelayed_choices
functions to keep track of that.NOTE
I thought about including the possibility of selecting the n-th element but I decided agains it. If the user knows that they want the n-th element speficically, they likely know what it is and can define it literally. Also, it opens the possibility of a range of elements (n:m) and that quickly escalates beyond reasonable granularity.
Let me know if you want an n-th choice option anyway, it can readily be added with this implementation.
ALTERNATIVE
See #232 for alternative implementation with separate functions.