-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Refine the vignettes #199
Conversation
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes, but after seeing the PR I get the feeling the window to get this reviewed and merged is too narrow.
As the vignettes would benefit from more details that would delay the release to CRAN.
On the other hand, adding that detail to deprecated it soon™ may not warrant doing it.
@chlebowa @averissimo What do you both think about removing the |
Agree! 👍 |
Agreed 👍 |
Code Coverage Summary
Diff against main
Results for commit: 0c121f8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 24 suites 6s ⏱️ Results for commit 0c121f8. ♻️ This comment has been updated with latest results. |
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
6bc3343
to
7814441
Compare
7814441
to
809427e
Compare
81fb811
to
94487ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @vedhav 👍
Closes #185
Changes:
Added a small vignette explaining how to createdata_extract_spec
teal.widgets
dependency as it's not needed.