Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes magrittr from Depends #188

Merged
merged 7 commits into from
Feb 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ repos:
- dplyr
- lifecycle
- logger
- magrittr
- methods
- rlang
- shiny
Expand Down
3 changes: 1 addition & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ URL: https://insightsengineering.github.io/teal.transform/,
https://github.com/insightsengineering/teal.transform/
BugReports: https://github.com/insightsengineering/teal.transform/issues
Depends:
magrittr (>= 1.5),
averissimo marked this conversation as resolved.
Show resolved Hide resolved
R (>= 3.6)
Imports:
checkmate (>= 2.1.0),
Expand All @@ -46,7 +45,7 @@ VignetteBuilder:
knitr
RdMacros:
lifecycle
Config/Needs/verdepcheck: tidyverse/magrittr, mllg/checkmate,
Config/Needs/verdepcheck: mllg/checkmate,
tidyverse/dplyr, r-lib/lifecycle, daroczig/logger, r-lib/rlang,
rstudio/rmarkdown, rstudio/shiny, daattali/shinyjs,
rstudio/shinyvalidate, insightsengineering/teal.data,
Expand Down
3 changes: 2 additions & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ S3method(value_choices,character)
S3method(value_choices,data.frame)
S3method(variable_choices,character)
S3method(variable_choices,data.frame)
export("%>%")
export(add_no_selected_choices)
export(all_choices)
export(check_no_multiple_selection)
Expand Down Expand Up @@ -66,5 +67,5 @@ export(split_by_sep)
export(value_choices)
export(variable_choices)
import(shiny)
importFrom(dplyr,"%>%")
importFrom(lifecycle,badge)
importFrom(magrittr,"%>%")
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
# teal.transform 0.4.0.9019

### Breaking changes

* Namespace from `magrittr` package is no longer available when loading `teal.transform`. Only re-exports pipe `%>%` operator from `dplyr` package.
averissimo marked this conversation as resolved.
Show resolved Hide resolved

### Miscellaneous

* Removed `magrittr` from package dependencies.
* Specified minimal version of package dependencies.

# teal.transform 0.4.0
Expand Down
5 changes: 4 additions & 1 deletion R/teal.transform-package.R
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
"_PACKAGE"

#' @import shiny
#' @importFrom magrittr %>%
#' @importFrom dplyr %>%
#' @importFrom lifecycle badge
NULL

#' @export
dplyr::`%>%`
16 changes: 16 additions & 0 deletions man/reexports.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading