tdata to teal_data

[gogonzo]

This is a feature branch, DON'T MERGE and DON'T COMMENT. PR open to have a constant checks. We will start review this PR as a whole in the sprint 4.

Summary

• removed all occurrences of TealData and friends (enemies),
• removed dependency on teal.slice
• fixed data_extract_multiple_srv and merge_expression_srv to work with (reactive) teal_data Fix datasets arg in data_extract_srv, merge_expression_srv to work with teal_data #159,
• fixed data_extract_ui to be independent from data. Now, data_extract_ui can be initialized with "delayed" specs and choices/selected are updated by the server on init. [Bug]: Concept of delayed creates indirect dependency between data and UI elements #111
• removed deprecated data_merge_module Remove data_merge_module and data_merge_srv in next release afrer 0.3.1 #144

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
delayed_data_extract	💚	$1.40$	$-1.32$	$-17$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
choices_selected	💀	$0.10$	$-0.10$	unnamed
data_extract_module	💀	$0.01$	$-0.01$	get_initial_filters_values_returns_all_column_values_and_the_selected_option_if_choices_is_NULL
data_extract_module	💀	$0.01$	$-0.01$	get_initial_filters_values_returns_empty_strings_if_vars_selected_is_NULL
data_extract_module	💀	$0.01$	$-0.01$	get_initial_filters_values_returns_the_selected_and_choices_if_they_are_not_null
data_extract_multiple_srv	👶		$+0.01$	data_extract_multiple_srv_accepts_datasets_as_FilteredData
data_extract_multiple_srv	💀	$0.03$	$-0.03$	data_extract_multiple_srv_accepts_datasets_as_FilteredData_or_list_of_reactive_data.frame
data_extract_multiple_srv	👶		$+0.01$	data_extract_multiple_srv_accepts_datasets_as_list_of_data.frame
data_extract_multiple_srv	👶		$+0.01$	data_extract_multiple_srv_accepts_datasets_list_of_reactive_data.frame
data_extract_spec	💀	$0.01$	$-0.01$	data_extract_spec_argument_checking
data_extract_spec	👶		$+0.01$	data_extract_spec_throws_when_select_is_not_select_spec_or_NULL
data_extract_srv	💀	$0.07$	$-0.07$	data_extract_srv_accepts_a_FilteredData_object_or_a_list_of_reactive_data_frames_to_datasets
data_extract_srv	👶		$+0.03$	data_extract_srv_datasets_accepts_a_FilteredData
data_extract_srv	👶		$+0.03$	data_extract_srv_datasets_accepts_a_list_of_data_frames
data_extract_srv	👶		$+0.04$	data_extract_srv_datasets_accepts_a_mixed_list_of_reactive_and_not_reactive_data_frames
data_extract_srv	👶		$+0.04$	data_extract_srv_datasets_accepts_list_of_reactive_data_frames
data_extract_srv	👶		$+0.03$	data_extract_srv_throws_error_when_data_extract_spec_is_missing
data_extract_srv	💀	$0.03$	$-0.03$	data_extract_srv_throws_error_with_missing_arguments
data_extract_srv	💀	$0.14$	$-0.14$	data_extract_srv_throws_error_with_wrong_argument_input_type
data_extract_srv	👶		$+0.13$	data_extract_srv_throws_when_data_extract_spec_don_t_get_data_extract_spec_object
delayed_data_extract	💀	$0.06$	$-0.06$	Delayed_choices_selected_single_data_connector_with_two_scda_dataset_connectors_resolve_delayed
delayed_data_extract	💀	$0.07$	$-0.07$	Delayed_data_extract_single_data_connector_with_two_scda_dataset_connectors_resolve_delayed
delayed_data_extract	💀	$0.22$	$-0.22$	Delayed_extract_TealData_with_single_dataset_and_multiple_connectors
delayed_data_extract	💀	$0.18$	$-0.18$	Delayed_extract_TealData_with_single_dataset_and_multiple_connectors_resolve_delayed
delayed_data_extract	💀	$0.12$	$-0.12$	Delayed_extract_filter_concatenated_single_data_connector_with_two_scda_dataset_connectors
delayed_data_extract	💀	$0.12$	$-0.12$	Delayed_extract_filter_concatenated_single_data_connector_with_two_scda_dataset_connectors_res_delayed
delayed_data_extract	💀	$0.16$	$-0.16$	Delayed_extract_two_filters_single_data_connector_with_two_scda_dataset_connectors
delayed_data_extract	💀	$0.17$	$-0.17$	Delayed_extract_two_filters_single_data_connector_with_two_scda_dataset_connectors_resolve_delayed
format_data_extract	💀	$0.00$	$-0.00$	format_data_extract_integrates_with_data_extract_srv_and_the_filtered_data_object
resolve	💀	$0.01$	$-0.01$	resolving_delayed_choices_removes_selected_not_in_choices_and_give_a_log_output

Results for commit 38ff81b

♻️ This comment has been updated with latest results.

[github-actions]

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------------------------------------------------------------------------------
R/all_choices.R                       1       0  100.00%
R/call_utils.R                      156     124  20.51%   14-23, 64, 66, 68, 107-431
R/check_selector.R                   32       0  100.00%
R/choices_labeled.R                 158      27  82.91%   59, 65, 70, 77, 93, 207-211, 215-220, 339-340, 342, 348, 374-381
R/choices_selected.R                 74      11  85.14%   191-219, 250
R/column_functions.R                  3       3  0.00%    13-16
R/data_extract_datanames.R           30       8  73.33%   9-13, 62-64
R/data_extract_filter_module.R      102      47  53.92%   87-100, 102-103, 105-122, 145-164
R/data_extract_module.R             300      68  77.33%   3, 115, 120, 137, 140-145, 147, 166-169, 197-243, 469, 474, 653, 663-664, 726-731
R/data_extract_read_module.R        137       7  94.89%   29, 34-36, 38, 133, 150
R/data_extract_select_module.R       32      18  43.75%   31-48
R/data_extract_single_module.R       60       2  96.67%   29, 42
R/data_extract_spec.R                32       0  100.00%
R/filter_spec.R                     186       1  99.46%   304
R/format_data_extract.R              16       1  93.75%   43
R/get_dplyr_call.R                  301       0  100.00%
R/get_merge_call.R                  280      29  89.64%   28-34, 45, 206-215, 369, 385-397
R/include_css_js.R                    5       0  100.00%
R/input_checks.R                     11       2  81.82%   18-19
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  135       6  95.56%   77, 227-231
R/merge_expression_module.R          60      11  81.67%   153-158, 175, 354-359
R/Queue.R                            23       0  100.00%
R/resolve_delayed.R                  16       4  75.00%   76-79
R/resolve.R                         114      44  61.40%   227-310
R/select_spec.R                      49       8  83.67%   103, 167-174
R/utils.R                            37      24  35.14%   26-39, 161-174
R/zzz.R                               2       2  0.00%    2-3
TOTAL                              2354     447  81.01%

Diff against main

Filename                          Stmts    Miss  Cover
------------------------------  -------  ------  --------
R/check_selector.R                   +1       0  +100.00%
R/choices_labeled.R                 -41     -27  +10.05%
R/choices_selected.R                 -7       0  -1.28%
R/data_extract_datanames.R           -2       0  -1.67%
R/data_extract_filter_module.R       +7     +31  -29.24%
R/data_extract_module.R              +2      +2  -0.52%
R/data_extract_read_module.R         +2       0  +0.08%
R/data_extract_single_module.R       +7       0  +0.44%
R/merge_expression_module.R         +11     +10  -16.29%
R/resolve_delayed.R                   0      +4  -25.00%
R/utils.R                           +13     +13  -19.03%
TOTAL                                -7     +33  -1.38%

Results for commit: 58832a6

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

    1 files    24 suites   6s ⏱️
189 tests 189 ✔️ 0 💤 0 ❌
659 runs  659 ✔️ 0 💤 0 ❌

Results for commit 58832a6.

♻️ This comment has been updated with latest results.

[chlebowa]

What little I can say.

Unless these are going to be removed soon, please prefix isolate etc. with shiny:: in unit tests.