Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JoinKeys related changes due to refactor #160

Merged
merged 15 commits into from
Nov 20, 2023
Merged

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Nov 3, 2023

Related to teal.data PR #184
Make changes to teal.transform because of the refactor to the JoinKeys class from R6 to S3.

vedhav and others added 2 commits November 7, 2023 19:14
Co-authored-by: Dawid Kałędkowski <[email protected]>
Signed-off-by: Vedha Viyash <[email protected]>
Co-authored-by: Dawid Kałędkowski <[email protected]>
Signed-off-by: Vedha Viyash <[email protected]>
@vedhav vedhav marked this pull request as ready for review November 8, 2023 06:48
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Unit Tests Summary

    1 files    24 suites   7s ⏱️
198 tests 197 ✔️ 1 💤 0
688 runs  687 ✔️ 1 💤 0

Results for commit a55f412.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ------------------------------------------------------------------------
R/all_choices.R                       1       0  100.00%
R/call_utils.R                      156     124  20.51%   14-23, 64, 66, 68, 107-431
R/check_selector.R                   31       0  100.00%
R/choices_labeled.R                 199      54  72.86%   59, 65, 70, 77, 93, 214-218, 222-227, 257-270, 382-383, 385, 433-465
R/choices_selected.R                 81      11  86.42%   200-228, 259
R/column_functions.R                  3       3  0.00%    13-16
R/data_extract_datanames.R           32       8  75.00%   9-13, 64-66
R/data_extract_filter_module.R       95      16  83.16%   75-88, 90-91, 145
R/data_extract_module.R             298      66  77.85%   3, 115, 120, 137, 140-145, 147, 166-169, 197-243, 476, 481, 660, 726-731
R/data_extract_read_module.R        135       7  94.81%   29, 33-36, 131, 148
R/data_extract_select_module.R       32      18  43.75%   31-48
R/data_extract_single_module.R       53       2  96.23%   29, 42
R/data_extract_spec.R                32       0  100.00%
R/data_merge_module.R                 2       2  0.00%    27-60
R/filter_spec.R                     186       1  99.46%   302
R/format_data_extract.R              16       1  93.75%   49
R/get_dplyr_call.R                  301       0  100.00%
R/get_merge_call.R                  280      29  89.64%   28-34, 45, 206-215, 369, 385-397
R/include_css_js.R                    5       0  100.00%
R/input_checks.R                     11       2  81.82%   18-19
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  135       6  95.56%   77, 227-231
R/merge_expression_module.R          49       1  97.96%   146
R/Queue.R                            23       0  100.00%
R/resolve_delayed.R                  16       0  100.00%
R/resolve.R                         114      44  61.40%   227-310
R/select_spec.R                      49       8  83.67%   103, 167-174
R/utils.R                            24      11  54.17%   26-39
R/zzz.R                               2       2  0.00%    2-3
TOTAL                              2363     416  82.40%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  --------
R/get_dplyr_call.R       +2       0  +100.00%
TOTAL                    +2       0  +0.01%

Results for commit: a55f412

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
choices_selected 👶 $+0.11$ unnamed
data_extract_multiple_srv 💀 $0.02$ $-0.02$ data_extract_multiple_srv_accepts_throws_error_when_join_keys_argument_is_not_JoinKeys_object
data_extract_multiple_srv 👶 $+0.01$ data_extract_multiple_srv_accepts_throws_error_when_join_keys_argument_is_not_join_keys_object
data_extract_srv 💀 $0.02$ $-0.02$ data_extract_srv_accepts_throws_error_when_join_keys_argument_is_not_a_JoinKeys_object
data_extract_srv 👶 $+0.01$ data_extract_srv_accepts_throws_error_when_join_keys_argument_is_not_a_join_keys_object
merge_expression_srv 💀 $0.02$ $-0.02$ merge_expression_srv_throws_error_if_join_keys_is_not_a_JoinKeys_object
merge_expression_srv 👶 $+0.02$ merge_expression_srv_throws_error_if_join_keys_is_not_a_join_keys_object

Results for commit cd4f3c3

♻️ This comment has been updated with latest results.

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vedhav vedhav enabled auto-merge (squash) November 20, 2023 10:31
@vedhav vedhav merged commit f82c7fc into main Nov 20, 2023
24 checks passed
@vedhav vedhav deleted the 78_simplify_joinkeys@main branch November 20, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Change JoinKeys to something simpler
3 participants