Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: add first_choice function #229

Open
3 tasks done
chlebowa opened this issue Dec 17, 2024 · 2 comments · May be fixed by #231 or #232
Open
3 tasks done

[Feature Request]: add first_choice function #229

chlebowa opened this issue Dec 17, 2024 · 2 comments · May be fixed by #231 or #232
Labels
enhancement

Comments

@chlebowa
Copy link
Contributor

Feature description

When creating choices_selected with delayed_data, selected can either be NULL or all_choices(). It would be nice to be able to select the first available choice so as not to start the app with an empty selection and validation errors.

image

all_choices seems to be resolved in only one place:
https://github.com/insightsengineering/teal.transform/blob/340994c392ab78056c40bcee05450d2bfa42cbe2/R/data_extract_filter_module.R#L151C1-L155C6

This could be achieved either by adding a new function, e.g. first_choice, last_choice, or adding arguments to all_choices.

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@gogonzo
Copy link
Contributor

gogonzo commented Dec 17, 2024 •
edited
Loading

This is a good idea! @donyunardi I'm ready to review and coordinate this collaboration 👍

@chlebowa
Copy link
Contributor Author

Thanks, I'll prepare a proposal soon.

This was referenced Dec 18, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@gogonzo @chlebowa