-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
229 delayed_choices
as separate funcitons
#232
Open
chlebowa
wants to merge
14
commits into
insightsengineering:main
Choose a base branch
from
chlebowa:229_delayed_choices_separate@main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
229 delayed_choices
as separate funcitons
#232
chlebowa
wants to merge
14
commits into
insightsengineering:main
from
chlebowa:229_delayed_choices_separate@main
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlebowa
changed the title
229 delayed choices separate@main
229 delayed choices as separate funcitons
Dec 19, 2024
chlebowa
changed the title
229 delayed choices as separate funcitons
229 Dec 19, 2024
delayed_choices
as separate funcitons
I like this approach more as About the exact implementation and other details I haven't reviewed it, but at first glance I'd like the explore the call to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #229
Alternative to #231
CHANGES
Added
first_choice
andlast_choice
to extendall_choices
functionality to subsets of available choices.IMPLEMENTATION
all_choices
,first_choice
, andlast_choice
are functions of classdelayed_choices
.delayed_choices
functions will add the appropriate subsetting operation to the$subset
element of theirdelayed_data argument
. Atomic arguments are returned as is.all_choices
is still a special case when checking arguments in some functions (choices
vsmultiple
) so an extra class is added to theall_choices
function to keep track of that.