Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Concept of delayed creates indirect dependency between data and UI elements #111

Assignees

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Nov 24, 2022

What happened?

UI elements of data_extract depends on the data_extract_spec. This means that to initialize UI it's required to have a complete information about the choices/selected. Because we allow to specify delayed_ it means that in between teal calls resolve_delayed(data, <delayed_xxx>).

This is a serious problem which we can solve in several ways:

  • remove data from the ui of teal_module. It must be absolutely prohibited.

  • move some of the content of data_extract_filter_ui and data_extract_select_ui to be rendered by server (either renderUI or updateInput).

  • Consider removing delayed_ and resolve_delayed from the package. Here is the reasoning for this:

    ✅ App developer always have the access to the data before any user start to use the app.
    ✅ App developer knows the data, it's columns and factor levels so one can specify data_extract_spec manualy each time
    ❌ Dataset in the source changes so the choices of the factor levels might change
    ❌ App user can select any data from the data source so app developer can't foresee what kind of inputs are needed. Is it actially possible that users can select any dataset to the app created by the app developer?

sessionInfo()

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@gogonzo
Copy link
Contributor Author

gogonzo commented Dec 5, 2023

implemented on the feature branch

@gogonzo gogonzo closed this as completed Dec 5, 2023
@gogonzo gogonzo reopened this Dec 12, 2023
@gogonzo gogonzo linked a pull request Dec 12, 2023 that will close this issue
@gogonzo gogonzo linked a pull request Dec 12, 2023 that will close this issue
@gogonzo gogonzo linked a pull request Dec 12, 2023 that will close this issue
@gogonzo gogonzo linked a pull request Dec 12, 2023 that will close this issue
@gogonzo gogonzo linked a pull request Dec 12, 2023 that will close this issue
gogonzo added a commit to insightsengineering/teal.goshawk that referenced this issue Dec 13, 2023
gogonzo added a commit to insightsengineering/teal.modules.clinical that referenced this issue Dec 13, 2023
gogonzo added a commit to insightsengineering/teal.modules.general that referenced this issue Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment