-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Concept of delayed creates indirect dependency between data and UI elements #111
Closed
3 tasks done
gogonzo opened this issue
Nov 24, 2022
· 1 comment
· Fixed by insightsengineering/teal#1006, #168, insightsengineering/teal.modules.general#618, insightsengineering/teal.modules.clinical#909 or insightsengineering/teal.goshawk#252
Closed
3 tasks done
[Bug]: Concept of delayed creates indirect dependency between data and UI elements #111
gogonzo opened this issue
Nov 24, 2022
· 1 comment
· Fixed by insightsengineering/teal#1006, #168, insightsengineering/teal.modules.general#618, insightsengineering/teal.modules.clinical#909 or insightsengineering/teal.goshawk#252
Comments
Merged
implemented on the feature branch |
Merged
Merged
gogonzo
added a commit
to insightsengineering/teal.goshawk
that referenced
this issue
Dec 13, 2023
gogonzo
added a commit
to insightsengineering/teal.modules.clinical
that referenced
this issue
Dec 13, 2023
gogonzo
added a commit
to insightsengineering/teal.modules.general
that referenced
this issue
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
UI elements of data_extract depends on the
data_extract_spec
. This means that to initialize UI it's required to have a complete information about the choices/selected. Because we allow to specifydelayed_
it means that in between teal callsresolve_delayed(data, <delayed_xxx>)
.This is a serious problem which we can solve in several ways:
remove
data
from theui
ofteal_module
. It must be absolutely prohibited.move some of the content of
data_extract_filter_ui
anddata_extract_select_ui
to be rendered by server (either renderUI or updateInput).Consider removing
delayed_
andresolve_delayed
from the package. Here is the reasoning for this:✅ App developer always have the access to the data before any user start to use the app.
✅ App developer knows the data, it's columns and factor levels so one can specify data_extract_spec manualy each time
❌ Dataset in the source changes so the choices of the factor levels might change
❌ App user can select any data from the data source so app developer can't foresee what kind of inputs are needed. Is it actially possible that users can select any dataset to the app created by the app developer?
sessionInfo()
No response
Relevant log output
No response
Code of Conduct
Contribution Guidelines
Security Policy
The text was updated successfully, but these errors were encountered: