Skip to content

Commit

Permalink
445 unify html tags tags (#203)
Browse files Browse the repository at this point in the history
part of insightsengineering/teal.slice#445
for teal.transform package
  • Loading branch information
kartikeyakirar authored Mar 7, 2024
1 parent cff50ef commit b56bbbb
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion R/data_extract_filter_module.R
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ data_extract_filter_ui <- function(filter, id = "filter") {
fixed = filter$fixed
)

div(
tags$div(
class = "filter_spec",
if (filter$vars_fixed) shinyjs::hidden(html_col) else html_col,
html_vals
Expand Down
4 changes: 2 additions & 2 deletions R/data_extract_module.R
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ cond_data_extract_single_ui <- function(ns, single_data_extract_spec) {
#' # Call to use inside your teal module UI function
#' standard_layout(
#' output = tableOutput("table"),
#' encoding = div(
#' encoding = tags$div(
#' data_extract_ui(
#' id = "regressor",
#' label = "Regressor Variable",
Expand Down Expand Up @@ -172,7 +172,7 @@ data_extract_ui <- function(id, label, data_extract_spec, is_single_dataset = FA
}
tagList(
include_css_files(pattern = "data_extract"),
div(
tags$div(
class = "data-extract",
tags$label(label),
dataset_input,
Expand Down
4 changes: 2 additions & 2 deletions R/data_extract_single_module.R
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ data_extract_single_ui <- function(id = NULL, single_data_extract_spec) {
## filter input
extract_spec_filter <- single_data_extract_spec$filter
filter_display <- do.call(
div,
tags$div,
lapply(
seq_along(extract_spec_filter),
function(idx) {
Expand Down Expand Up @@ -57,7 +57,7 @@ data_extract_single_ui <- function(id = NULL, single_data_extract_spec) {
if (!extract_spec_reshape) reshape_display <- shinyjs::hidden(reshape_display)

## all combined
div(filter_display, select_display, reshape_display)
tags$div(filter_display, select_display, reshape_display)
}

#' The server function for a single `data_extract_spec` object
Expand Down
4 changes: 2 additions & 2 deletions R/merge_expression_module.R
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
#'
#' ui <- fluidPage(
#' standard_layout(
#' output = div(
#' output = tags$div(
#' verbatimTextOutput("expr"),
#' dataTableOutput("data")
#' ),
Expand Down Expand Up @@ -280,7 +280,7 @@ merge_expression_module.list <- function(datasets,
#'
#' ui <- fluidPage(
#' standard_layout(
#' output = div(
#' output = tags$div(
#' verbatimTextOutput("expr"),
#' dataTableOutput("data")
#' ),
Expand Down
2 changes: 1 addition & 1 deletion man/data_extract_ui.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/merge_expression_module.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/merge_expression_srv.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vignettes/data-extract-merge.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ merge_ui <- function(id, data_extracts) {
sidebarLayout(
sidebarPanel(
h3("Encoding"),
div(
tags$div(
data_extract_ui(
ns("adsl_extract"), # must correspond with data_extracts list names
label = "ADSL extract",
Expand Down
2 changes: 1 addition & 1 deletion vignettes/data-merge.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ merge_ui <- function(id, data_extracts) {
sidebarLayout(
sidebarPanel(
h3("Encoding"),
div(
tags$div(
data_extract_ui(
ns("adsl_extract"), # must correspond with data_extracts list names
label = "ADSL extract",
Expand Down

0 comments on commit b56bbbb

Please sign in to comment.