-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update min version of testthat and precommit config #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Tests Summary 1 files 29 suites 23s ⏱️ Results for commit 0cdcdd4. ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 0cdcdd4 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
averissimo
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar with insightsengineering/teal.code#220, failure in min_isolated pipeline:
https://github.com/insightsengineering/teal.slice/actions/runs/11537362432/job/32114685586#step:9:1346
Summary:
Update testthat minimum version due to usage of
testthat::it()
in DESCRIPTION file:https://github.com/insightsengineering/teal.slice/blob/main/tests/testthat/test-utils.R#L9
Add
teal.code
to the pre-commit configuration to allow it to use the development version when running. This is necessary because the development version ofteal.data
requires the development version ofteal.code
to run, and without this, the pre-commit will fail.