Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

52 standardise optional notation #567

Merged
merged 20 commits into from
Mar 14, 2024
Merged

Conversation

kartikeyakirar
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Mar 5, 2024

badge

Code Coverage Summary

Filename                        Stmts    Miss  Cover    Missing
----------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------------------------------------
R/calls_combine_by.R                7       0  100.00%
R/choices_labeled.R                49      14  71.43%   25, 36, 41, 51-56, 68, 72-76
R/count_labels.R                   97       0  100.00%
R/filter_panel_api.R               29       1  96.55%   132
R/FilteredData-utils.R             68      25  63.24%   21-24, 27-30, 52-57, 153, 175-184
R/FilteredData.R                  562     227  59.61%   110, 184, 326, 398, 501-510, 533, 554-595, 613-616, 632, 673-706, 721-723, 727-733, 762-790, 813-815, 819-821, 824-838, 842-852, 855-898, 939, 962-984
R/FilteredDataset-utils.R          23       1  95.65%   125
R/FilteredDataset.R               170      61  64.12%   52, 152, 191, 216-273, 312-314
R/FilteredDatasetDataframe.R      121       8  93.39%   87, 148, 158, 234-238
R/FilteredDatasetDefault.R         18       4  77.78%   103-116
R/FilteredDatasetMAE.R            134      37  72.39%   56, 117-122, 161-166, 170-171, 189-211
R/FilterPanelAPI.R                 10       0  100.00%
R/FilterState-utils.R             101       2  98.02%   264, 294
R/FilterState.R                   361      61  83.10%   89, 212, 230-234, 241-242, 256-257, 263-264, 311, 313, 315, 367, 411, 639, 682-705, 715-734, 769-775, 784-790
R/FilterStateChoices.R            341     108  68.33%   310-313, 325, 367, 389-396, 400-417, 445, 458-469, 481-489, 493-522, 543-546, 549-552, 563-586, 597, 602, 613
R/FilterStateDate.R               212     129  39.15%   227, 279-436
R/FilterStateDatettime.R          309     199  35.60%   266, 318-549
R/FilterStateEmpty.R               53      31  41.51%   89, 99-104, 117, 129-169
R/FilterStateExpr.R                75      62  17.33%   149-272
R/FilterStateLogical.R            196     144  26.53%   136, 158, 218, 222-406
R/FilterStateRange.R              408     105  74.26%   262, 384, 510-514, 517-527, 530, 542-548, 559-571, 575-585, 589-591, 605-632, 647, 650, 664-681, 716-721, 731-733
R/FilterStates-utils.R             70       9  87.14%   108, 127, 188-194, 216, 245
R/FilterStates.R                  364      30  91.76%   78-82, 191, 314-323, 411-414, 457, 542-546, 591, 712-715
R/FilterStatesDF.R                  5       0  100.00%
R/FilterStatesMAE.R                10       1  90.00%   40
R/FilterStatesMatrix.R              3       0  100.00%
R/FilterStatesSE.R                211     157  25.59%   36, 71-73, 83-85, 109-116, 124-131, 154-302
R/include_css_js.R                  5       5  0.00%    12-16
R/teal_slice.R                    107       4  96.26%   134, 188-189, 200
R/teal_slices.R                    84       5  94.05%   144-149
R/test_utils.R                     21       0  100.00%
R/utils.R                          18       0  100.00%
R/variable_types.R                 15       8  46.67%   44-51
R/zzz.R                            16      16  0.00%    3-46
TOTAL                            4273    1454  65.97%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 688c157

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Unit Tests Summary

  1 files   29 suites   22s ⏱️
359 tests 359 ✅ 0 💤 0 ❌
824 runs  824 ✅ 0 💤 0 ❌

Results for commit 688c157.

♻️ This comment has been updated with latest results.

R/FilterStates-utils.R Outdated Show resolved Hide resolved
R/FilterStates.R Outdated Show resolved Hide resolved
R/FilterStatesDF.R Outdated Show resolved Hide resolved
R/FilterStatesMAE.R Outdated Show resolved Hide resolved
R/FilterStatesMatrix.R Outdated Show resolved Hide resolved
R/FilterStatesSE.R Outdated Show resolved Hide resolved
R/FilteredData.R Outdated Show resolved Hide resolved
R/FilteredDataset-utils.R Outdated Show resolved Hide resolved
R/FilteredDataset.R Outdated Show resolved Hide resolved
R/FilteredDatasetDataframe.R Outdated Show resolved Hide resolved
R/FilteredDatasetMAE.R Outdated Show resolved Hide resolved
R/teal_slice.R Outdated Show resolved Hide resolved
R/teal_slice.R Outdated Show resolved Hide resolved
R/teal_slice.R Outdated Show resolved Hide resolved
R/teal_slice.R Outdated Show resolved Hide resolved
R/teal_slice.R Outdated Show resolved Hide resolved
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, there are 2 places that requires a re-write. In other suggestions I proposed to remove commas before nouns.

kartikeyakirar and others added 7 commits March 14, 2024 18:41
Co-authored-by: Marcin <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Marcin <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Marcin <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Marcin <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Marcin <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Marcin <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Marcin <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
@kartikeyakirar kartikeyakirar requested a review from m7pr March 14, 2024 13:38
@kartikeyakirar kartikeyakirar merged commit a8b89a9 into main Mar 14, 2024
24 checks passed
@kartikeyakirar kartikeyakirar deleted the 52_standardise_optional@main branch March 14, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants