-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
445 unify html tags #566
445 unify html tags #566
Conversation
Code Coverage Summary
Diff against main
Results for commit: 3fc5c61 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 29 suites 22s ⏱️ Results for commit 3fc5c61. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shiny::
prefixes are superfluous because of @import shiny
. Please revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I believe you caught everything!
tests still have shiny::
prefix, but that shouldn't block this.
@chlebowa anything to add?
fixes #445