-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds min package version #405
Conversation
Thanks @averissimo . How often should we do this exercise? Is it going to be scheduled weekly and verify min ver of packages? |
@m7pr I believe the idea is for this to be executed weekly per This will alert for whenever a new API is used that the min_version doesn't support, but it will also alert to breaking changes that are appearing in GitHub (so that we can act early on, before the CRAN release of "that" package) |
Sounds great, really cool feature |
6218ecf
to
6bc8b6e
Compare
6bc8b6e
to
be0ca39
Compare
6b788a1
to
a5ab9a3
Compare
Reported here: #466 All other strategies are working See here (manually triggered): https://github.com/insightsengineering/teal.slice/actions/runs/6247937554 |
Code Coverage Summary
Diff against main
Results for commit: 8b6d4b8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Retriggering the job in Actions menu https://github.com/insightsengineering/teal.slice/actions/runs/6249307143 for verdepcheck branch as I saw last run failed |
@averissimo |
just heard over the meeting that failure for |
WIP :: parent issue: insightsengineering/nestdevs-tasks#7
Supersede:
🔴 Checklist for PR Reviewer
(see comment below)
main
rmarkdown
(may have been removed onSuggests
)Imports
,Depends
&Suggests
are in new sectionConfig/Needs/verdepcheck
NEWS.md
scheduled.yaml
action was run succesfully (all 4 strategies)Scheduled 🕰️ / Dependency
actionsscheduled.yaml
SHOULD NOT have any push on any branches🔴 What's needed before merging?
This PR depends on some upstream changes that need to be finalized/merged before being ready to review.
Change in code
verdepcheck.yml
action (see comments)on: push
sectionPRS
min_isolated
andmin_cohort
r-verdepcheck-action#16Changes description
DESCRIPTION
Config/Need/verdepcheck
section inDESCRIPTION