Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tdata in tealdata@main #212

Closed
wants to merge 7 commits into from
Closed

Tdata in tealdata@main #212

wants to merge 7 commits into from

Conversation

mhallal1
Copy link
Contributor

@mhallal1 mhallal1 commented Feb 24, 2023

related to insightsengineering/teal.data#121

-updated init_filtered_data to take tdata and not TealData
-updated tests

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
init_filtered_data 💀 $0.01$ $-0.01$ init_filtered_data_accepts_a_TealData_object
init_filtered_data 👶 $+0.02$ init_filtered_data_accepts_a_tdata_object_of_a_tealData_object

Results for commit ed2d834

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    29 suites   23s ⏱️
423 tests 423 ✔️ 0 💤 0
747 runs  747 ✔️ 0 💤 0

Results for commit ad9dffa.

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/call_utils.R                  156       4  97.44%   141-144
R/choices_labeled.R              49      14  71.43%   19, 30, 35, 45-50, 62, 66-70
R/filter_state_api.R             17      17  0.00%    137-172
R/FilteredData-utils.R           98      43  56.12%   126-131, 223-270
R/FilteredData.R                505     267  47.13%   139, 249-253, 302-316, 368-382, 717-849, 877-879, 883-886, 890-894, 898-900, 929-935, 942-944, 946-947, 955, 961-966, 984-989, 1012-1020, 1023-1048, 1063-1078, 1130-1151, 1175
R/FilteredDataCDISC.R           152      28  81.58%   92, 115, 124, 128, 142-151, 255-262, 280-283, 289, 354-357
R/FilteredDataset.R             188      77  59.04%   103, 199, 298, 362-419, 461-463, 502-508, 545-555
R/FilteredDatasetDefault.R      106       8  92.45%   166-173
R/FilteredDatasetMAE.R          208      59  71.63%   28, 119, 251-327
R/FilterPanelAPI.R               23       8  65.22%   88, 119-125
R/FilterState-utils.R           131      14  89.31%   154, 253-259, 271-276
R/FilterState.R                 230      88  61.74%   114-115, 236, 362-408, 521-593
R/FilterStateChoices.R          153      96  37.25%   210-216, 229, 255-356
R/FilterStateDate.R             163     108  33.74%   201-207, 220, 224, 255-371
R/FilterStateDatettime.R        223     164  26.46%   124-126, 219-225, 239, 243, 274-447
R/FilterStateEmpty.R             41      16  60.98%   132-158
R/FilterStateLogical.R          137      86  37.23%   193-199, 213, 229-321
R/FilterStateRange.R            229     136  40.61%   322-328, 338-339, 343-349, 366-523
R/FilterStates-utils.R           68       5  92.65%   96, 113, 160, 206, 227
R/FilterStates.R                226      93  58.85%   94-100, 170, 229, 319-513, 530-531, 540
R/FilterStatesDF.R              230      29  87.39%   196-198, 202-210, 212, 216-218, 220, 386-395, 454, 523
R/FilterStatesMAE.R             221     106  52.04%   30, 90-95, 234-356, 373
R/FilterStatesMatrix.R          217     108  50.23%   39, 71-76, 84-85, 87, 135-136, 222-340
R/FilterStatesSE.R              409     201  50.86%   24, 90-95, 128-133, 140-141, 143, 304-313, 348-355, 363-370, 398-567
R/include_css_js.R                5       5  0.00%    12-16
R/resolve_state.R                23       0  100.00%
R/utils.R                        39       2  94.87%   101-102
R/variable_types.R               48      33  31.25%   42-47, 57, 70-105
R/zzz.R                           6       6  0.00%    3-11
TOTAL                          4301    1821  57.66%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ed2d834

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@gogonzo gogonzo closed this Jul 13, 2023
@gogonzo gogonzo deleted the tdata_in_tealdata@main branch July 13, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants