fix: extend fix to other occurences of label

insightsengineering · Feb 19, 2024 · 5d9e0c5 · 5d9e0c5
1 parent 558e3b8
commit 5d9e0c5
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -14,7 +14,7 @@
 
 ### Bug fixes
 
-* Performs an exact match on `init_filtered_dataset` when determining the default label of a dataset.
+* Performs an exact match when determining the default label of a dataset from attributes.
 
 ### Miscellaneous
 

diff --git a/R/FilterState.R b/R/FilterState.R
@@ -96,7 +96,7 @@ FilterState <- R6::R6Class( # nolint
       if (is.null(isolate(slice$keep_na)) && anyNA(x)) slice$keep_na <- TRUE
       private$teal_slice <- slice
       # Obtain variable label.
-      varlabel <- attr(x, "label")
+      varlabel <- attr(x, "label", exact = TRUE)
       # Display only when different from varname.
       private$varlabel <-
         if (is.null(varlabel) || identical(varlabel, private$get_varname())) {

diff --git a/R/FilterStateChoices.R b/R/FilterStateChoices.R
@@ -159,7 +159,7 @@ ChoicesFilterState <- R6::R6Class( # nolint
         x_factor <- if (!is.factor(x)) {
           structure(
             factor(as.character(x), levels = as.character(sort(unique(x)))),
-            label = attr(x, "label")
+            label = attr(x, "label", exact = TRUE)
           )
         } else {
           x

diff --git a/R/FilteredDataset.R b/R/FilteredDataset.R
@@ -29,7 +29,7 @@ FilteredDataset <- R6::R6Class( # nolint
     #'
     #' @return Object of class `FilteredDataset`, invisibly.
     #'
-    initialize = function(dataset, dataname, keys = character(0), label = attr(dataset, "label")) {
+    initialize = function(dataset, dataname, keys = character(0), label = attr(dataset, "label", exact = TRUE)) {
       logger::log_trace("Instantiating { class(self)[1] }, dataname: { dataname }")
 
       # dataset assertion in child classes

diff --git a/man/FilteredDataset.Rd b/man/FilteredDataset.Rd