Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add staged.deps yaml file #47

Merged
merged 4 commits into from
May 23, 2022
Merged

add staged.deps yaml file #47

merged 4 commits into from
May 23, 2022

Conversation

nikolas-burkoff
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff commented May 18, 2022

Part of #5 along with insightsengineering/teal#635

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2022

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  ---------------------------------------------
R/AddCardModule.R        77       3  96.10%   54-56
R/ContentBlock.R         16       0  100.00%
R/DownloadModule.R      137      24  82.48%   74-76, 97, 154-158, 161-165, 172-176, 179-183
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         31       0  100.00%
R/Previewer.R           215      11  94.88%   156, 158-161, 166-172
R/Renderer.R             54       4  92.59%   142, 144-145, 166
R/ReportCard.R           47       0  100.00%
R/Reporter.R             43       0  100.00%
R/ResetModule.R          45       0  100.00%
R/SimpleReporter.R       14       0  100.00%
R/TableBlock.R            9       0  100.00%
R/TealReportCard.R        9       0  100.00%
R/TextBlock.R             7       0  100.00%
R/yaml_utils.R           74       2  97.30%   65, 260
TOTAL                   780      44  94.36%

Results for commit: 167aaed

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@denisovan31415 denisovan31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikolas-burkoff
Copy link
Contributor Author

Blocked - awaiting teal and rtables PR

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2022

Unit Tests Summary

    1 files    15 suites   7s ⏱️
135 tests 135 ✔️ 0 💤 0
184 runs  184 ✔️ 0 💤 0

Results for commit a01eeb7.

♻️ This comment has been updated with latest results.

@kpagacz
Copy link
Contributor

kpagacz commented May 23, 2022

Is this still blocked?

@nikolas-burkoff
Copy link
Contributor Author

So these three need to go in together:

@nikolas-burkoff nikolas-burkoff merged commit ba7b76f into main May 23, 2022
@nikolas-burkoff nikolas-burkoff deleted the 5_reporter_in_teal@main branch May 23, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants