Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple reporter updates #32

Merged
merged 9 commits into from
May 9, 2022
Merged

Simple reporter updates #32

merged 9 commits into from
May 9, 2022

Conversation

mhallal1
Copy link
Contributor

@mhallal1 mhallal1 commented May 6, 2022 •
edited
Loading

closes #30 and #31

  • added ResetModule to add the reset button outisde of download page.
  • added tryCatch for zipping and copying the files in the download module that throw error notifications when failing.
  • updated the SimpleReport to not render the comment block if the comment was empty.
  • Added a notification when a card is added.

Test with simple reporter example.

@mhallal1 mhallal1 added the core label May 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022 •
edited
Loading

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  ---------------------------------------------------
R/AddCardModule.R        77       3  96.10%   54-56
R/ContentBlock.R         16       0  100.00%
R/DownloadModule.R      140      25  82.14%   77-79, 100, 126, 159-163, 166-170, 177-181, 184-188
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         31       0  100.00%
R/Renderer.R             54       8  85.19%   142, 144-145, 155-157, 164, 166
R/ReportCard.R           43       0  100.00%
R/Reporter.R             17       0  100.00%
R/ResetModule.R          45       0  100.00%
R/SimpleReporter.R       14       0  100.00%
R/TableBlock.R            9       0  100.00%
R/TealReportCard.R        9       0  100.00%
R/TextBlock.R             7       0  100.00%
R/yaml_utils.R           74       2  97.30%   66, 265
TOTAL                   538      38  92.94%

Results for commit: 94696f4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022 •
edited
Loading

Unit Tests Summary

    1 files    14 suites   6s ⏱️
125 tests 125 ✔️ 0 💤 0 ❌
168 runs  168 ✔️ 0 💤 0 ❌

Results for commit ce03734.

♻️ This comment has been updated with latest results.

@kpagacz kpagacz self-assigned this May 9, 2022
kpagacz
kpagacz reviewed May 9, 2022
View reviewed changes
R/ResetModule.R Outdated Show resolved Hide resolved
@kpagacz
* changed the inputText comment area in add_card_button_srv to
d4efd9f 
  textAreaInput
* replaced the default value of the said input with a placeholder
  value and changed its wording
* changed the colors of cancel button in SimpleReporter to red
kpagacz
kpagacz approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@kpagacz kpagacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teal.reporter has a tagged release so I think this might be an excellent starting point for writing NEWS entries.

It looks good!

@mhallal1 mhallal1 merged commit c7822ab into main May 9, 2022
@mhallal1 mhallal1 deleted the 30_simple_reporter@main branch May 9, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpagacz kpagacz kpagacz approved these changes

Assignees

@kpagacz kpagacz

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the simple reporter module
2 participants
@mhallal1 @kpagacz