Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade testthat #297

Merged
merged 1 commit into from
Jan 14, 2025
Merged

upgrade testthat #297

merged 1 commit into from
Jan 14, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 14, 2025

testthat 3.2.2 is required, to pull waldo 0.6.0 so that compare_proxy function works as expected. currently it fails 4 tests on min_isolated strategy

Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
@m7pr m7pr added the core label Jan 14, 2025
@m7pr m7pr requested a review from llrs-roche January 14, 2025 08:33
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Unit Tests Summary

  1 files   19 suites   29s ⏱️
197 tests 197 ✅ 0 💤 0 ❌
337 runs  337 ✅ 0 💤 0 ❌

Results for commit b94ef28.

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor Author

m7pr commented Jan 14, 2025

This supposed to fix this CI for min_cohort
https://github.com/insightsengineering/teal.reporter/actions/runs/12764364403

@llrs-roche llrs-roche self-assigned this Jan 14, 2025
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@m7pr m7pr merged commit bd85e78 into main Jan 14, 2025
34 of 36 checks passed
@m7pr m7pr deleted the fix_ci@main-1 branch January 14, 2025 09:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants