-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow html content to be added to a report #294
Conversation
Unit Tests Summary 1 files 19 suites 28s ⏱️ Results for commit fa72347. ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: fa72347 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Signed-off-by: Vedha Viyash <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accept this solution as proposed conversion plotly -> html to include to include directly in md is not sufficient for pdf (there is no way to convert html in md to static image in pdf). Please add tests of the:
- htmlBlock class
- ReportCars$append_html
- Renderer$htmlBlock2md
Unit Test Performance Difference
Additional test case details
Results for commit 51e2c6b ♻️ This comment has been updated with latest results. |
Closes #129
It turns out that interactive plots can be rendered by saving them in an
RDS
file and fetching them just like how we do the reports for table objects.Example app to test interactive plots in a report. Note that not all HTML content can be rendered in static documents like
pdf
,pptx
, andword
. But popular plotting packages that use have the ability for static render.I don't know yet if all
htmlwidget
objects can do this, but I am inclined to believe this is the case asecharts4r
package is a light htmlwidgets wrapper over the apache echarts JS library.